[maven-pmd-plugin] branch master updated: [MPMD-300] - Unable to format output with custom renderer (CodeClimateRenderer)

[ad...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

adangel pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-pmd-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 4d241d4  [MPMD-300] - Unable to format output with custom renderer (CodeClimateRenderer)
4d241d4 is described below

commit 4d241d475fcdd1b38e60abbb18f4a387c106e2de
Author: Andreas Dangel <ad...@apache.org>
AuthorDate: Thu Apr 9 19:22:07 2020 +0200

    [MPMD-300] - Unable to format output with custom renderer (CodeClimateRenderer)
---
 .../java/org/apache/maven/plugins/pmd/PmdReport.java  |  4 +---
 .../org/apache/maven/plugins/pmd/PmdReportTest.java   | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
index d7005cf..8af58e0 100644
--- a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
+++ b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
@@ -31,7 +31,6 @@ import java.util.Arrays;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
-import java.util.Properties;
 import java.util.ResourceBundle;
 
 import org.apache.maven.doxia.sink.Sink;
@@ -896,8 +895,7 @@ public class PmdReport
         {
             try
             {
-                result = (Renderer) Class.forName( format ).getConstructor( Properties.class ).
-                                newInstance( new Properties() );
+                result = (Renderer) Class.forName( format ).getConstructor().newInstance();
             }
             catch ( Exception e )
             {
diff --git a/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java b/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
index 70d6ed0..3bb5b04 100644
--- a/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
+++ b/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
@@ -32,8 +32,11 @@ import java.util.Locale;
 
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.reporting.MavenReportException;
 import org.codehaus.plexus.util.FileUtils;
 
+import net.sourceforge.pmd.renderers.Renderer;
+
 import com.github.tomakehurst.wiremock.WireMockServer;
 import com.github.tomakehurst.wiremock.client.WireMock;
 
@@ -669,4 +672,20 @@ public class PmdReportTest
 
             assertEquals(0, StringUtils.countMatches(str, "<violation"));
         }
+
+    public void testCustomRenderer() throws MavenReportException
+    {
+        PmdReport pmdReport = new PmdReport();
+        pmdReport.format = "net.sourceforge.pmd.renderers.TextRenderer";
+        final Renderer renderer = pmdReport.createRenderer();
+        assertNotNull(renderer);
+    }
+
+    public void testCodeClimateRenderer() throws MavenReportException
+    {
+        PmdReport pmdReport = new PmdReport();
+        pmdReport.format = "net.sourceforge.pmd.renderers.CodeClimateRenderer";
+        final Renderer renderer = pmdReport.createRenderer();
+        assertNotNull(renderer);
+    }
 }