[GitHub] [incubator-superset] graceguo-supercat commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion 👩‍🎤

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion 👩‍🎤
URL: https://github.com/apache/incubator-superset/issues/9123#issuecomment-586057763
 
 
   Thanks @rusackas for making this SIP. 
   I happened to see [this article](https://www.developerdrive.com/best-css-in-js-libraries/) recently. I am very interested in this feature from `JSS`:
   
   > JSS is a framework-agnostic CSS-in-JS library with which you can dynamically generate CSS styles based on the state of your components. 
   
   I had a small feature already in the dashboard code that can be much cleaner if i had a help from any framework:
   https://github.com/apache/incubator-superset/blob/291306392443a5a0d0e2ee0cc4a95d37c56d4589/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx#L72
   In the above code, when user click on filter indicator on a chart, I want to show an animation on a dropdown in the filter_box that contains the user interested field. Without css-in-js, I need to pass props between nested React components which is kind of very troublesome (and cause many unnecessary rerendering).
   
   Can Emotion handle this case easily? I am new to all css-in-js libraries. Once we decided, i'd like to re-write this module to use our pick. Thanks!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org