You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by jd...@apache.org on 2017/04/27 03:18:23 UTC
[3/3] kudu git commit: Improve unsupported application feature flags
error status
Improve unsupported application feature flags error status
It can be helpful to have the exact set of unsupported flags when
debugging compatibility issues.
Change-Id: Ie59fba2b5ff57a22d16c7b7eca55ab4581e9b64c
Reviewed-on: http://gerrit.cloudera.org:8080/6722
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1edaee01
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1edaee01
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1edaee01
Branch: refs/heads/master
Commit: 1edaee01f55f83eb1c8cb5f21daa11c3753d183b
Parents: 2be32d5
Author: Dan Burkert <da...@apache.org>
Authored: Mon Apr 24 18:28:42 2017 -0700
Committer: Jean-Daniel Cryans <jd...@apache.org>
Committed: Thu Apr 27 03:17:36 2017 +0000
----------------------------------------------------------------------
src/kudu/rpc/service_pool.cc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/1edaee01/src/kudu/rpc/service_pool.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/service_pool.cc b/src/kudu/rpc/service_pool.cc
index d089350..1a23ca9 100644
--- a/src/kudu/rpc/service_pool.cc
+++ b/src/kudu/rpc/service_pool.cc
@@ -24,11 +24,12 @@
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/ref_counted.h"
+#include "kudu/gutil/strings/join.h"
+#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/inbound_call.h"
#include "kudu/rpc/messenger.h"
#include "kudu/rpc/service_if.h"
#include "kudu/rpc/service_queue.h"
-#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/logging.h"
#include "kudu/util/metrics.h"
#include "kudu/util/status.h"
@@ -137,7 +138,10 @@ Status ServicePool::QueueInboundCall(gscoped_ptr<InboundCall> call) {
if (!unsupported_features.empty()) {
c->RespondUnsupportedFeature(unsupported_features);
- return Status::NotSupported("call requires unsupported application feature flags");
+ return Status::NotSupported("call requires unsupported application feature flags",
+ JoinMapped(unsupported_features,
+ [] (uint32_t flag) { return std::to_string(flag); },
+ ", "));
}
TRACE_TO(c->trace(), "Inserting onto call queue");