You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2018/02/05 18:12:36 UTC
Review Request 65508: Allow curl program to be properly executed on
Windows platform.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715
Repository: mesos
Description
-------
Allow curl program to be properly executed on Windows platform.
Diffs
-----
src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
Diff: https://reviews.apache.org/r/65508/diff/1/
Testing
-------
Full build, unit tests on both Linux and Windows platform.
Thanks,
Jeff Coffler
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Jeff Coffler <je...@taltos.com>.
> On Feb. 6, 2018, 7:12 p.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy of the summary.
>
> Jeff Coffler wrote:
> This was a one-line commit, but I went ahead and added a second line. I'm not sure why you said that the description shouldn't be a copy of the summary, it wasn't. Tooling problem on your side, or just a mistake?
>
> Andrew Schwartzmeyer wrote:
> When you post a review with just a summary, the scripts copy the summary into the description. This unfortunately carries through to the other side when the review is applied, and then you have a weird commit. The (work-around?) is to not post one-line commit messages.
>
> Jeff Coffler wrote:
> That's odd. I think you mentioned this before, but I see one-line commits on Mesos, like this:
>
> ```
> commit 2ef5f4a
> Author: Gilbert Song <so...@gmail.com>
> Date: Thu Feb 8 08:45:42 2018
>
> Added an image 1.3-1.5_v1_json_state_query_latency.png to docs/images.
>
> commit f7dbd29
> Author: Michael Park <mp...@apache.org>
> Date: Wed Feb 7 20:28:42 2018
>
> Updated ReviewBot to use Ubuntu 16.04.
> ```
>
> Am I doing something wrong. Do I need something "funny" in the description (like a "." or something) if it's one line?
Talked F2F with Andy. This is a tooling issue. One-line commits are possible, if after rbt, the copy of the one-line commit is removed from the "Description" field.
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196911
-----------------------------------------------------------
On Feb. 5, 2018, 6:12 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:12 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Jeff Coffler <je...@taltos.com>.
> On Feb. 6, 2018, 7:12 p.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy of the summary.
>
> Jeff Coffler wrote:
> This was a one-line commit, but I went ahead and added a second line. I'm not sure why you said that the description shouldn't be a copy of the summary, it wasn't. Tooling problem on your side, or just a mistake?
>
> Andrew Schwartzmeyer wrote:
> When you post a review with just a summary, the scripts copy the summary into the description. This unfortunately carries through to the other side when the review is applied, and then you have a weird commit. The (work-around?) is to not post one-line commit messages.
That's odd. I think you mentioned this before, but I see one-line commits on Mesos, like this:
```
commit 2ef5f4a
Author: Gilbert Song <so...@gmail.com>
Date: Thu Feb 8 08:45:42 2018
Added an image 1.3-1.5_v1_json_state_query_latency.png to docs/images.
commit f7dbd29
Author: Michael Park <mp...@apache.org>
Date: Wed Feb 7 20:28:42 2018
Updated ReviewBot to use Ubuntu 16.04.
```
Am I doing something wrong. Do I need something "funny" in the description (like a "." or something) if it's one line?
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196911
-----------------------------------------------------------
On Feb. 5, 2018, 6:12 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:12 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Feb. 6, 2018, 11:12 a.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy of the summary.
>
> Jeff Coffler wrote:
> This was a one-line commit, but I went ahead and added a second line. I'm not sure why you said that the description shouldn't be a copy of the summary, it wasn't. Tooling problem on your side, or just a mistake?
When you post a review with just a summary, the scripts copy the summary into the description. This unfortunately carries through to the other side when the review is applied, and then you have a weird commit. The (work-around?) is to not post one-line commit messages.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196911
-----------------------------------------------------------
On Feb. 5, 2018, 10:12 a.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 10:12 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Jeff Coffler <je...@taltos.com>.
> On Feb. 6, 2018, 7:12 p.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy of the summary.
This was a one-line commit, but I went ahead and added a second line. I'm not sure why you said that the description shouldn't be a copy of the summary, it wasn't. Tooling problem on your side, or just a mistake?
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196911
-----------------------------------------------------------
On Feb. 5, 2018, 6:12 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:12 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196911
-----------------------------------------------------------
Ship it!
Nit: Fix summary to be in past tense, and fix description to not be a copy of the summary.
- Andrew Schwartzmeyer
On Feb. 5, 2018, 10:12 a.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 10:12 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196910
-----------------------------------------------------------
src/uri/fetchers/curl.cpp
Line 99 (original), 99-104 (patched)
<https://reviews.apache.org/r/65508/#comment276904>
Nit: Run `clang-format` please; line 99 is >80 chars.
- Andrew Schwartzmeyer
On Feb. 5, 2018, 10:12 a.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 10:12 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65508: Allowed curl program to be properly
executed on Windows platform.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 11:09 p.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Summary (updated)
-----------------
Allowed curl program to be properly executed on Windows platform.
Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715
Repository: mesos
Description (updated)
-------
On Windows, "curl.exe" must be executed rather then "curl".
Diffs (updated)
-----
src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
Diff: https://reviews.apache.org/r/65508/diff/2/
Changes: https://reviews.apache.org/r/65508/diff/1-2/
Testing
-------
Full build, unit tests on both Linux and Windows platform.
Thanks,
Jeff Coffler
Re: Review Request 65508: Allow curl program to be properly executed
on Windows platform.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196825
-----------------------------------------------------------
PASS: Mesos patch 65508 was successfully built and tested.
Reviews applied: `['65508']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65508
- Mesos Reviewbot Windows
On Feb. 5, 2018, 6:12 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:12 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow curl program to be properly executed on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd
>
>
> Diff: https://reviews.apache.org/r/65508/diff/1/
>
>
> Testing
> -------
>
> Full build, unit tests on both Linux and Windows platform.
>
>
> Thanks,
>
> Jeff Coffler
>
>