You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kl...@apache.org on 2016/04/27 01:44:08 UTC

[1/4] incubator-geode git commit: Use TemporaryFolder

Repository: incubator-geode
Updated Branches:
  refs/heads/feature/GEODE-1276 74c625edb -> a4008236c


Use TemporaryFolder


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/d92ffc40
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/d92ffc40
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/d92ffc40

Branch: refs/heads/feature/GEODE-1276
Commit: d92ffc406c20195fc33d673e009c2fb788747a33
Parents: 74c625e
Author: Kirk Lund <kl...@apache.org>
Authored: Tue Apr 26 16:21:08 2016 -0700
Committer: Kirk Lund <kl...@apache.org>
Committed: Tue Apr 26 16:21:08 2016 -0700

----------------------------------------------------------------------
 .../gemfire/internal/StatSamplerJUnitTest.java     | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/d92ffc40/geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
index 90bd869..f0ea81a 100755
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
@@ -31,6 +31,7 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.junit.contrib.java.lang.system.RestoreSystemProperties;
 import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
 import org.junit.rules.TestName;
 
 import com.gemstone.gemfire.CancelCriterion;
@@ -57,6 +58,9 @@ public class StatSamplerJUnitTest {
   public RestoreSystemProperties restoreSystemProperties = new RestoreSystemProperties();
 
   @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Rule
   public TestName testName = new TestName();
 
   @Before
@@ -72,15 +76,22 @@ public class StatSamplerJUnitTest {
     StatisticsTypeFactoryImpl.clear();
     StatArchiveWriter.clearTraceFilter();
   }
+
+  private String getName() {
+    return getClass().getSimpleName() + "_" + testName.getMethodName();
+  }
   
   @Test
   public void testStatSampler() throws Exception {
     StatArchiveWriter.setTraceFilter("st1_1", "ST1");
-    
+
+    File folder = temporaryFolder.newFolder();
+    String archiveFileName = folder.getAbsolutePath() + File.separator + getName() + ".gfs";
+
     System.setProperty("stats.log-level", "config");
     System.setProperty("stats.disable", "false");
-    System.setProperty("stats.name", getClass().getSimpleName() + "_" + testName.getMethodName());
-    System.setProperty("stats.archive-file", getClass().getSimpleName() + "_" + testName.getMethodName() + ".gfs");
+    System.setProperty("stats.name", getName());
+    System.setProperty("stats.archive-file", archiveFileName);
     System.setProperty("stats.file-size-limit", "0");
     System.setProperty("stats.disk-space-limit", "0");
     System.setProperty("stats.sample-rate", "100");


[4/4] incubator-geode git commit: Add missing @Test and other test cleanup

Posted by kl...@apache.org.
Add missing @Test and other test cleanup


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/a4008236
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/a4008236
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/a4008236

Branch: refs/heads/feature/GEODE-1276
Commit: a4008236cb3f77b69ee8739d1f86ae87c99fcf2b
Parents: 4f6ca83
Author: Kirk Lund <kl...@apache.org>
Authored: Tue Apr 26 16:43:47 2016 -0700
Committer: Kirk Lund <kl...@apache.org>
Committed: Tue Apr 26 16:43:47 2016 -0700

----------------------------------------------------------------------
 .../ParallelGatewaySenderQueueJUnitTest.java        |  3 ---
 ...tSerialGatewaySenderEventProcessorJUnitTest.java | 16 ++++++++++++----
 .../cache/xmlcache/AbstractXmlParserJUnitTest.java  |  2 +-
 3 files changed, 13 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/a4008236/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
index c85be1e..0e4d193 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
@@ -19,7 +19,6 @@ package com.gemstone.gemfire.internal.cache.wan.parallel;
 import static org.junit.Assert.*;
 import static org.mockito.Mockito.*;
 
-import java.io.IOException;
 import java.util.Collections;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 
@@ -30,8 +29,6 @@ import org.junit.experimental.categories.Category;
 import com.gemstone.gemfire.CancelCriterion;
 import com.gemstone.gemfire.cache.DataPolicy;
 import com.gemstone.gemfire.cache.PartitionAttributesFactory;
-import com.gemstone.gemfire.cache.RegionExistsException;
-import com.gemstone.gemfire.cache.TimeoutException;
 import com.gemstone.gemfire.internal.cache.GemFireCacheImpl;
 import com.gemstone.gemfire.internal.cache.PartitionedRegion;
 import com.gemstone.gemfire.internal.cache.PartitionedRegionDataStore;

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/a4008236/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java
index e26d287..37962e9 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java
@@ -19,6 +19,7 @@ package com.gemstone.gemfire.internal.cache.wan.serial;
 import static org.junit.Assert.*;
 import static org.mockito.Mockito.*;
 
+import org.junit.Before;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
@@ -29,12 +30,19 @@ import com.gemstone.gemfire.test.junit.categories.UnitTest;
 @Category(UnitTest.class)
 public class ConcurrentSerialGatewaySenderEventProcessorJUnitTest {
 
-  @Test
-  public void eventQueueSizeReturnsSizeOfQueues() {
+  private ConcurrentSerialGatewaySenderEventProcessor processor;
+  private RegionQueue queue;
+
+  @Before
+  public void setUp() throws Exception {
     AbstractGatewaySender sender = mock(AbstractGatewaySender.class);
-    ConcurrentSerialGatewaySenderEventProcessor processor = new ConcurrentSerialGatewaySenderEventProcessor(sender);
-    RegionQueue queue = mock(RegionQueue.class);
+    processor = new ConcurrentSerialGatewaySenderEventProcessor(sender);
+    queue = mock(RegionQueue.class);
     when(queue.size()).thenReturn(3);
+  }
+
+  @Test
+  public void eventQueueSizeReturnsSizeOfQueues() {
     processor.getQueues().add(queue);
     assertEquals(3,processor.eventQueueSize());
   }

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/a4008236/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractXmlParserJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractXmlParserJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractXmlParserJUnitTest.java
index 8e9e2a4..104a706 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractXmlParserJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractXmlParserJUnitTest.java
@@ -14,7 +14,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package com.gemstone.gemfire.internal.cache.xmlcache;
 
 import static org.junit.Assert.*;
@@ -51,6 +50,7 @@ public class AbstractXmlParserJUnitTest {
   /**
    * Test method for {@link AbstractXmlParser#setDocumentLocator(Locator)}.
    */
+  @Test
   public void testSetDocumentLocator() {
     final MockXmlParser mockXmlParser = new MockXmlParser();
     final Locator mockLocator = new Locator() {


[3/4] incubator-geode git commit: Test cleanup

Posted by kl...@apache.org.
Test cleanup


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/4f6ca83b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/4f6ca83b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/4f6ca83b

Branch: refs/heads/feature/GEODE-1276
Commit: 4f6ca83b082d752b2b0734e5f159fb35585075d9
Parents: 555bc8b
Author: Kirk Lund <kl...@apache.org>
Authored: Tue Apr 26 16:39:40 2016 -0700
Committer: Kirk Lund <kl...@apache.org>
Committed: Tue Apr 26 16:39:40 2016 -0700

----------------------------------------------------------------------
 .../versions/RegionVersionHolderJUnitTest.java  | 52 +++++++++++++-------
 .../RegionVersionHolderRandomJUnitTest.java     | 47 +++++-------------
 ...RegionVersionHolderSmallBitSetJUnitTest.java | 15 ++----
 3 files changed, 52 insertions(+), 62 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/4f6ca83b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderJUnitTest.java
index 731f466..b2a74f0 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderJUnitTest.java
@@ -16,33 +16,47 @@
  */
 package com.gemstone.gemfire.internal.cache.versions;
 
-import java.io.FileReader;
-import java.io.Reader;
+import static org.junit.Assert.*;
+
 import java.net.InetAddress;
 import java.util.BitSet;
 
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
-import junit.framework.TestCase;
-
 import com.gemstone.gemfire.distributed.internal.membership.InternalDistributedMember;
 import com.gemstone.gemfire.internal.Assert;
 import com.gemstone.gemfire.internal.cache.versions.RVVException.ReceivedVersionsIterator;
 import com.gemstone.gemfire.test.junit.categories.UnitTest;
 
 @Category(UnitTest.class)
-public class RegionVersionHolderJUnitTest extends TestCase {
-  
-  protected InternalDistributedMember member;
-  
-  int originalBitSetWidth = RegionVersionHolder.BIT_SET_WIDTH;
+public class RegionVersionHolderJUnitTest {
+
+  private int originalBitSetWidth;
+  private InternalDistributedMember member;
 
-  @Override
-  protected void setUp() throws Exception {
-    super.setUp();
+  @Before
+  public final void setUp() throws Exception {
+    originalBitSetWidth = RegionVersionHolder.BIT_SET_WIDTH;
     member = new InternalDistributedMember(InetAddress.getLocalHost(), 12345);
+    postSetUp();
   }
-  
+
+  protected void postSetUp() throws Exception {
+  }
+
+  @After
+  public final void tearDown() throws Exception {
+    RegionVersionHolder.BIT_SET_WIDTH = originalBitSetWidth;
+  }
+
+  protected final InternalDistributedMember member() {
+    return member;
+  }
+
+  @Test
   public void test48066_1() {
     RegionVersionHolder vh1 = new RegionVersionHolder(member);
     for (int i=1; i<=3; i++) {
@@ -74,7 +88,8 @@ public class RegionVersionHolderJUnitTest extends TestCase {
       assertEquals(7, vh3.getVersion());
     }
   }
-   
+
+  @Test
   public void test48066() {
     RegionVersionHolder vh = new RegionVersionHolder(member);
     BitSet bs = new BitSet();
@@ -1472,6 +1487,7 @@ public class RegionVersionHolderJUnitTest extends TestCase {
   /**
    * Test merging two version holders
    */
+  @Test
   public void testInitializeFrom() {
     testInitializeFrom(false);
     testInitializeFrom(true);
@@ -1587,6 +1603,7 @@ public class RegionVersionHolderJUnitTest extends TestCase {
    * Test a case in 46522 where the received exceptions end up 
    * not being in the RVV interval.
    */
+  @Test
   public void testConsumeReceivedRevisions() {
     testConsumeReceivedRevisions(false);
     testConsumeReceivedRevisions(true);
@@ -1630,7 +1647,8 @@ public class RegionVersionHolderJUnitTest extends TestCase {
       RVVException.UseTreeSetsForTesting = false;
     }
   }
-  
+
+  @Test
   public void testChangeSetForm() {
     try {
       RVVException.UseTreeSetsForTesting = true;
@@ -1667,12 +1685,12 @@ public class RegionVersionHolderJUnitTest extends TestCase {
    * 
    * See bug 47106
    */
+  @Test
   public void testDominates() {
     testDominates(false);
     testDominates(true);
   }
-  
-  
+
   private void testDominates(boolean useTreeSets) {
     try {
       RVVException.UseTreeSetsForTesting = useTreeSets;

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/4f6ca83b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderRandomJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderRandomJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderRandomJUnitTest.java
index d60a354..7821b6d 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderRandomJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderRandomJUnitTest.java
@@ -16,18 +16,18 @@
  */
 package com.gemstone.gemfire.internal.cache.versions;
 
-import it.unimi.dsi.fastutil.ints.IntOpenHashSet;
+import static org.junit.Assert.*;
 
-import java.net.InetAddress;
 import java.util.ArrayList;
 import java.util.BitSet;
 import java.util.Collections;
 import java.util.List;
 import java.util.Random;
 
+import it.unimi.dsi.fastutil.ints.IntOpenHashSet;
+import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
-import com.gemstone.gemfire.distributed.internal.membership.InternalDistributedMember;
 import com.gemstone.gemfire.test.junit.categories.UnitTest;
 
 /**
@@ -41,32 +41,16 @@ import com.gemstone.gemfire.test.junit.categories.UnitTest;
 @Category(UnitTest.class)
 public class RegionVersionHolderRandomJUnitTest extends RegionVersionHolderSmallBitSetJUnitTest {
   
-  Random random = new Random();
-  
+  private Random random;
+
   @Override
-  protected void setUp() throws Exception {
-    super.setUp();
+  protected final void postSetUpRegionVersionHolderSmallBitSetJUnitTest() throws Exception {
     long seed = System.nanoTime();
-//    seed = 1194319178069961L;
-    random.setSeed(seed);
+    random = new Random();
+    random.setSeed(seed); // 1194319178069961L;
     System.out.println("RegionVersionHolderJUnitTest using random seed " + seed);
   }
   
-  
-  int loopNum = 0;
-  /**
-   * Rerun all of the tests several times to see if anything fails.
-   * @throws InterruptedException
-   */
-//  public void testLoop() throws InterruptedException {
-//    for(int i =0; i < 50; i++) {
-//      loopNum=i;
-//      System.err.println("i=" + i);
-//      testInitializeFrom();
-//      testConsumeReceivedRevisions();
-//      testParallelThreads();
-//    }
-//  }
   /**
    * Record versions in random order, rather than in sequential order
    * This should generate and fill some exceptions.
@@ -92,17 +76,16 @@ public class RegionVersionHolderRandomJUnitTest extends RegionVersionHolderSmall
    * This tries to be a more "real life" test. A bunch of threads perform
    * updates, which should create exceptions. Verify that the final
    * exception list is correct.
-   * @throws InterruptedException
    */
+  @Test
   public void testParallelThreads() throws InterruptedException {
-    RegionVersionHolder vh1 = new RegionVersionHolder(member);
-    RegionVersionHolder vh2 = new RegionVersionHolder(member);
+    RegionVersionHolder vh1 = new RegionVersionHolder(member());
+    RegionVersionHolder vh2 = new RegionVersionHolder(member());
     
     int UPDATES = 50000;
     int NUM_UPDATERS=20;
     int NUM_EXCEPTIONS=500;
-//    int NUM_EXCEPTIONS=0;
-    
+
     Random random = new Random();
     IntOpenHashSet exceptions = new IntOpenHashSet();
     for(int i =0; i < NUM_EXCEPTIONS; i++) {
@@ -136,13 +119,9 @@ public class RegionVersionHolderRandomJUnitTest extends RegionVersionHolderSmall
     for(int i = 1; i < UPDATES; i++) {
       assertEquals("vector is incorrect on item "+  i,!exceptions.contains(i), vh2.contains(i));
     }
-    
   }
-  
-  
-  
+
   private static class HolderUpdater extends Thread {
-    
 
     private int updates;
     private int myNumber;

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/4f6ca83b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderSmallBitSetJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderSmallBitSetJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderSmallBitSetJUnitTest.java
index 3c9f09e..bd6199b 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderSmallBitSetJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolderSmallBitSetJUnitTest.java
@@ -27,20 +27,13 @@ import com.gemstone.gemfire.test.junit.categories.UnitTest;
 @Category(UnitTest.class)
 public class RegionVersionHolderSmallBitSetJUnitTest extends RegionVersionHolderJUnitTest {
   
-  
   @Override
-  protected void setUp() throws Exception {
-    super.setUp();
-    originalBitSetWidth = RegionVersionHolder.BIT_SET_WIDTH;
+  protected final void postSetUp() throws Exception {
     RegionVersionHolder.BIT_SET_WIDTH = 4;
+    postSetUpRegionVersionHolderSmallBitSetJUnitTest();
   }
-  
-  protected void tearDown() throws Exception {
-    super.tearDown();
-    RegionVersionHolder.BIT_SET_WIDTH = originalBitSetWidth;
+
+  protected void postSetUpRegionVersionHolderSmallBitSetJUnitTest() throws Exception {
   }
-  
-  
-  
 
 }


[2/4] incubator-geode git commit: Use TemporaryFolder and TestName

Posted by kl...@apache.org.
Use TemporaryFolder and TestName


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/555bc8b0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/555bc8b0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/555bc8b0

Branch: refs/heads/feature/GEODE-1276
Commit: 555bc8b0923d98701ae14422d9feb975774619a6
Parents: d92ffc4
Author: Kirk Lund <kl...@apache.org>
Authored: Tue Apr 26 16:25:21 2016 -0700
Committer: Kirk Lund <kl...@apache.org>
Committed: Tue Apr 26 16:25:21 2016 -0700

----------------------------------------------------------------------
 .../LauncherLifecycleCommandsIntegrationTest.java       | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/555bc8b0/geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
----------------------------------------------------------------------
diff --git a/geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b/geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
index c7479bb..42e7291 100644
--- a/geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
+++ b/geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
@@ -32,8 +32,11 @@ import java.util.jar.Manifest;
 
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.rules.TestName;
 
 import com.gemstone.gemfire.internal.util.IOUtils;
 import com.gemstone.gemfire.test.junit.categories.IntegrationTest;
@@ -52,6 +55,12 @@ public class LauncherLifecycleCommandsIntegrationTest {
 
   private LauncherLifecycleCommands launcherCommands;
 
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Rule
+  public TestName testName = new TestName();
+
   @Before
   public void setup() {
     launcherCommands = new LauncherLifecycleCommands();
@@ -83,7 +92,8 @@ public class LauncherLifecycleCommandsIntegrationTest {
   public void testReadPid() throws IOException {
     final int expectedPid = 12345;
 
-    File pidFile = new File(getClass().getSimpleName().concat("_testReadPid.pid"));
+    File folder = temporaryFolder.newFolder();
+    File pidFile = new File(folder, getClass().getSimpleName() + "_" + testName.getMethodName() + ".pid");
 
     assertTrue(pidFile.createNewFile());