You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2009/06/06 21:11:51 UTC
[jira] Created: (CAMEL-1677) Remove dependency cycles between model
and sub packages
Remove dependency cycles between model and sub packages
-------------------------------------------------------
Key: CAMEL-1677
URL: https://issues.apache.org/activemq/browse/CAMEL-1677
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 2.0-M1
Reporter: Christian Schneider
Fix For: 2.0-M2
Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
I think the goal should be that model does not reference the subpackages.
The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1677) Remove dependency cycles between model
and sub packages
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-1677:
---------------------------------------
Attachment: model_after.png
model-before.png
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52112#action_52112 ]
Claus Ibsen commented on CAMEL-1677:
------------------------------------
Something that has bitten me before is the camel-scala.
Remember to test whether it still compiles. Maybe a few files need to be updated as well.
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-1677:
-----------------------------------
Assignee: Willem Jiang
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52117#action_52117 ]
Willem Jiang commented on CAMEL-1677:
-------------------------------------
@Christian,
Yes, I did this changes with the help of eclipse, it finds the reference in Java file and the scala file automatically, except the jaxb.index part.
And all the camel projects are opened in my eclipse workspace :)
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1677) Remove dependency cycles between model
and sub packages
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-1677:
---------------------------------------
Attachment: camel-core.patch
Movetwo classes to model to resolve cylces
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1677) Remove dependency cycles between model
and sub packages
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-1677:
---------------------------------------
Attachment: camel-core.patch
Smaller patch that does not include all eclipse-classes ;-)
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-1677.
---------------------------------
Resolution: Fixed
http://svn.apache.org/viewvc?rev=782535&view=rev
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52116#action_52116 ]
Willem Jiang commented on CAMEL-1677:
-------------------------------------
There are some other file need to update, such as
the jaxb.index file in the camel-core/resource, camel-scale which Claus mentioned, and the CamelNamespaceHandler in the camel-osgi.
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52115#action_52115 ]
Christian Schneider commented on CAMEL-1677:
--------------------------------------------
Oh and probably it is best you do not use the patch but rather move the classes in eclipse yourself. I had only camel-core open and I guess some other projects could also use these classes.
Btw. When you work on camel do you have all camel projects open in eclipse? I guess this could make work a little slow but for cases like above it is probably necessary.
Christian
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1677) Remove dependency cycles between
model and sub packages
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52111#action_52111 ]
Willem Jiang commented on CAMEL-1677:
-------------------------------------
@Christian ,
You patch doesn't include the change of CamelNamespaceHandler of the camel-spring module.
Don't worry, I will take care of it :)
Willem
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.0-M2
>
> Attachments: camel-core.patch, model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1677) Remove dependency cycles between model
and sub packages
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-1677:
---------------------------------------
Attachment: (was: camel-core.patch)
> Remove dependency cycles between model and sub packages
> -------------------------------------------------------
>
> Key: CAMEL-1677
> URL: https://issues.apache.org/activemq/browse/CAMEL-1677
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0-M1
> Reporter: Christian Schneider
> Fix For: 2.0-M2
>
> Attachments: model-before.png, model_after.png
>
>
> Currently there is a dependency cycle between model and model.loadbalancer and between model and model.dataformat. The reason in both cases that the base classes DataFormatDefinition and LoadBalancerDefinition are in the subpackages but are referenced from model.
> I think the goal should be that model does not reference the subpackages.
> The easy solution is to move the two classes above to model. After the move the cycles are gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.