You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "chihumyum (via GitHub)" <gi...@apache.org> on 2026/09/21 06:53:50 UTC
[PR] feat(desktop): steer running turns with Cmd/Ctrl+Enter [maka]
chihumyum opened a new pull request, #5560:
URL: https://github.com/apache/maka/pull/5560
## Summary
Use Cmd+Enter on macOS (Ctrl+Enter on Windows/Linux) to steer the current draft into a running turn once. Plain Enter and the Send button continue to queue follow-ups. Shift+Enter and Alt+Enter now insert a line break in both idle and running composers; Cmd/Ctrl+Enter sends normally while idle.
The shared composer covers the main conversation, Side Chat and WorkHub. Queue help, keyboard help, retry instructions and existing journeys use the new binding. Runtime admission, persistence and provider protocols are unchanged.
| While a turn is running | Before | After |
| --- | --- | --- |
| Enter / Send | Queue next turn | Queue next turn |
| Cmd/Ctrl+Enter | Queue next turn | Steer current turn once |
| Shift+Enter | Steer current turn | Insert line break |
## Verification
- `npm run build`, `npm run typecheck`, `npm run lint`, `npm run format:check` — passed.
- `npx knip --workspace apps/desktop` and `npx knip --workspace packages/ui` — passed.
- UI suite: **602 passed**, including **36 new component cases** covering Mac/Windows/Linux, idle/running, modifier precedence, IME, open mention menus, rejected/blocked sends, staged context and duplicate-key admission.
- Regression check: restoring the original Composer made **7 new tests fail on behavior**; the changed implementation passes all 36.
- Targeted Desktop/Runtime Host suites: **57 passed** (WorkHub send visibility, queue projection, turn-request composer, execution-host queue and interactive-run composer).
- Electron on macOS: **4 passed** — Side Chat queue actions/handoff/reconnect, ordinary Enter during delayed observation, steering after conversation remount, and WorkHub running prompt/queue/steering/help tooltip. Existing native journeys were updated; no additional Electron test declarations or fixture launches were added to the suite. `npm run check:e2e-budget` passed.
```text
UI: 602 passed, 0 failed
Desktop / Host: 57 passed, 0 failed
Electron journeys: 4 passed, 0 failed
```
Windows/Linux shortcut routing is covered by component tests; native desktop runs were on macOS with the deterministic test backend.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented the shortcut, localized hints, tests and documentation, ran validation, and prepared this PR. The commit includes `Generated-by: Codex`.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): steer running turns with Cmd/Ctrl+Enter [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5560:
URL: https://github.com/apache/maka/pull/5560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org