You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Mike Rheinheimer (JIRA)" <ji...@apache.org> on 2009/07/16 00:19:15 UTC
[jira] Created: (WINK-104) handle q=0 on Accept-Encoding http
header
handle q=0 on Accept-Encoding http header
-----------------------------------------
Key: WINK-104
URL: https://issues.apache.org/jira/browse/WINK-104
Project: Wink
Issue Type: Bug
Components: Server
Affects Versions: 0.1
Reporter: Mike Rheinheimer
Fix For: 0.1
Attachments: WINK-104.patch
HTTP Accept-Encoding header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WINK-104) handle q=0 on Accept http header
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman reassigned WINK-104:
----------------------------------
Assignee: Michael Elman
> handle q=0 on Accept http header
> --------------------------------
>
> Key: WINK-104
> URL: https://issues.apache.org/jira/browse/WINK-104
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-104.patch
>
>
> HTTP Accept header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
> Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
> To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
> If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-104) handle q=0 on Accept http header
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer closed WINK-104.
---------------------------------
> handle q=0 on Accept http header
> --------------------------------
>
> Key: WINK-104
> URL: https://issues.apache.org/jira/browse/WINK-104
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-104.patch
>
>
> HTTP Accept header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
> Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
> To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
> If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-104) handle q=0 on Accept http header
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-104:
----------------------------------
Description:
HTTP Accept header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
was:
HTTP Accept-Encoding header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
Summary: handle q=0 on Accept http header (was: handle q=0 on Accept-Encoding http header)
> handle q=0 on Accept http header
> --------------------------------
>
> Key: WINK-104
> URL: https://issues.apache.org/jira/browse/WINK-104
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Fix For: 0.1
>
> Attachments: WINK-104.patch
>
>
> HTTP Accept header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
> Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
> To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
> If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-104) handle q=0 on Accept-Encoding http
header
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-104:
----------------------------------
Attachment: WINK-104.patch
patch can be applied at wink-server
> handle q=0 on Accept-Encoding http header
> -----------------------------------------
>
> Key: WINK-104
> URL: https://issues.apache.org/jira/browse/WINK-104
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Fix For: 0.1
>
> Attachments: WINK-104.patch
>
>
> HTTP Accept-Encoding header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
> Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
> To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
> If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-104) handle q=0 on Accept http header
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman resolved WINK-104.
--------------------------------
Resolution: Fixed
Fixed it.
I needed to modify some of the unit tests, please see and tell me if you are agree with the changes.
There was a unit test under "TODO". I don't think that it should work. In this unit test the user returns explicit Response object with the defined media type. According to spec, the implementation should not interfere user defined type. see 3.8.1.
> handle q=0 on Accept http header
> --------------------------------
>
> Key: WINK-104
> URL: https://issues.apache.org/jira/browse/WINK-104
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-104.patch
>
>
> HTTP Accept header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
> Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
> To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
> If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-104) handle q=0 on Accept http header
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731967#action_12731967 ]
Hudson commented on WINK-104:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #15 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/15/])
handle q=0 on Accept http header
See []
> handle q=0 on Accept http header
> --------------------------------
>
> Key: WINK-104
> URL: https://issues.apache.org/jira/browse/WINK-104
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-104.patch
>
>
> HTTP Accept header can have q=0 quality factor. This indicates that the server should NOT send out that encoding.
> Please see patch for tests and possible solution. I will say, however, that I don't particularly like the solution. It's readable, and it works, but it's part of some filtering code that I think could be and should be optimized.
> To whomever commits this, please open a followup Jira to optimize that filtering code patch in ResourceRegistry.
> If you change the solution significantly, please email me or I'll check the Jira periodically to see if any updated patches were posted. I'm curious to see the solution(s) and learn how I can make your job easier. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.