[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter
URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325015375
 
 

 ##########
 File path: zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java
 ##########
 @@ -162,6 +162,8 @@ public String getInterpreterSettingName() {
   public void start(String userName) throws IOException {
     docker = DefaultDockerClient.builder().uri(URI.create(DOCKER_HOST)).build();
 
+    removeExistContainer(containerName);
 
 Review comment:
   Because docker can't create a container with the same name, it will cause the creation to fail.
   If the zeppelin service is abnormal and the container that was created is not closed properly, the container will not be created again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services