[GitHub] [hadoop] jojochuang commented on pull request #3538: HDFS-16266. Add remote port information to HDFS audit log

[GitBox <gi...@apache.org>]

jojochuang commented on pull request #3538:
URL: https://github.com/apache/hadoop/pull/3538#issuecomment-950643667


   The API is declared Public, Evolving. If it stays in Hadoop 3.4.0 I am fine with it.
   
   We used to have an audit logger (Cloudera Navigator) that extends the AuditLogger interface. But we've moved away from that.
   
   Performance:
   It would have a slight performance penalty because every audit log op will always convert InetAddress to a string, regardless if audit logger is off (audit log level = debug or dfs.namenode.audit.log.debug.cmdlist has the excluded op)). It's probably acceptable since audit is logged outside of namenode lock.
   
   CallerContext:
    the caller context is probably a better option when you want to do fine-grained post-mortem anyway. Maybe we can modify the caller context to attach remote port so that it doesn't break api compatibility. Just a thought.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org