[GitHub] [inlong] healchow commented on a diff in pull request #5053: [INLONG-5052][Manager] The workflow that failed to execute still failed, but returned success

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5053:
URL: https://github.com/apache/inlong/pull/5053#discussion_r921188413


##########
inlong-manager/manager-workflow/src/main/java/org/apache/inlong/manager/workflow/core/impl/TaskServiceImpl.java:
##########
@@ -67,6 +68,8 @@ public WorkflowContext transfer(Integer taskId, String remark, List<String> to,
     public WorkflowContext complete(Integer taskId, String remark, String operator) {
         WorkflowContext context = workflowContextBuilder
                 .buildContextForTask(taskId, WorkflowAction.COMPLETE, remark, operator);
+        ServiceTask serviceTask = (ServiceTask) context.getActionContext().getTask();

Review Comment:
   Are the results of `context.getActionContext().getTask()` all `ServiceTask`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org