You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/15 13:47:50 UTC
[GitHub] [spark] mohamadrezarostami opened a new pull request #34912: [SPARK-37060][CORE] Handle driver status response from backup masters
mohamadrezarostami opened a new pull request #34912:
URL: https://github.com/apache/spark/pull/34912
### What changes were proposed in this pull request?
After an improvement in SPARK-31486, contributor uses 'asyncSendToMasterAndForwardReply' method instead of 'activeMasterEndpoint.askSync' to get the status of driver. Since the driver's status is only available in active master and the 'asyncSendToMasterAndForwardReply' method iterate over all of the masters, we have to handle the response from the backup masters in the client, which the developer did not consider in the SPARK-31486 change. So drivers running in cluster mode and on a cluster with multi masters affected by this bug.
### Why are the changes needed?
We need to find if the response received from a backup master client must ignore it.
### Does this PR introduce _any_ user-facing change?
No, It's only fixed a bug and brings back the ability to deploy in cluster mode on multi-master clusters.
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #34912: [SPARK-37060][CORE][3.2] Handle driver status response from backup masters
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #34912:
URL: https://github.com/apache/spark/pull/34912#issuecomment-995509056
Thanks, merged to branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohamadrezarostami edited a comment on pull request #34912: [SPARK-37060][CORE] Handle driver status response from backup masters
Posted by GitBox <gi...@apache.org>.
mohamadrezarostami edited a comment on pull request #34912:
URL: https://github.com/apache/spark/pull/34912#issuecomment-994808823
@Ngone51
Based on our conversation in #34331 (comment), here is PR for branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohamadrezarostami commented on pull request #34912: [SPARK-37060][CORE] Handle driver status response from backup masters
Posted by GitBox <gi...@apache.org>.
mohamadrezarostami commented on pull request #34912:
URL: https://github.com/apache/spark/pull/34912#issuecomment-994808823
@Ngone51
Based on our conversation in #34331 (comment), here is PR for branch-3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 closed pull request #34912: [SPARK-37060][CORE][3.2] Handle driver status response from backup masters
Posted by GitBox <gi...@apache.org>.
Ngone51 closed pull request #34912:
URL: https://github.com/apache/spark/pull/34912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34912: [SPARK-37060][CORE] Handle driver status response from backup masters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34912:
URL: https://github.com/apache/spark/pull/34912#issuecomment-994836568
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org