You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/29 02:46:41 UTC

[GitHub] codecov-io commented on issue #4669: [sqllab] Rendering query prior to sending to Celery

codecov-io commented on issue #4669: [sqllab] Rendering query prior to sending to Celery
URL: https://github.com/apache/incubator-superset/pull/4669#issuecomment-375514113
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=h1) Report
   > Merging [#4669](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68dec245423a64808b6edb45ce2bedbbaf1a000d?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4669/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4669      +/-   ##
   ==========================================
   + Coverage   71.87%   71.88%   +<.01%     
   ==========================================
     Files         204      204              
     Lines       15323    15320       -3     
     Branches     1177     1177              
   ==========================================
   - Hits        11014    11013       -1     
   + Misses       4306     4304       -2     
     Partials        3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4669/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.55% <ø> (+0.95%)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4669/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.15% <66.66%> (-0.03%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=footer). Last update [68dec24...d41d747](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services