You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/04/08 20:41:49 UTC
Review Request 32982: Added reservation user guide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
Diffs
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On May 11, 2015, 9:51 a.m., Joerg Schad wrote:
> > docs/reservation.md, line 25
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25>
> >
> > s/existed prior/available since version x.x.x?
>
> Michael Park wrote:
> I went with `introduced in 0.14.0` here.
Actually decided to go with `since 0.14.0`
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83212
-----------------------------------------------------------
On June 26, 2015, 8:35 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 8:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: [WIP] Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On May 11, 2015, 9:51 a.m., Joerg Schad wrote:
> > docs/reservation.md, line 25
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25>
> >
> > s/existed prior/available since version x.x.x?
I went with `introduced in 0.14.0` here.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83212
-----------------------------------------------------------
On June 26, 2015, 3:36 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 3:36 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
> The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
> I'll update the guide to accurately reflect the master endpoints as it gets more solified.
> The purpose of including it was/is to get initial feedback on how it generally works.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83212
-----------------------------------------------------------
Ship it!
LGTM, I didn't test the examples though.
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment134112>
s/existed prior/available since version x.x.x?
- Joerg Schad
On May 8, 2015, 6:57 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 6:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: Do not commit until master API endpoints are implemented for dynamic reservations.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 243
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line243>
> >
> > What happens if you try to unreserve a reservation that is being used right now?
The reason why we go through the offer cycle is to eliminate the case where a framework could attempt to unreserve resources that are being used. That is, we know that the resources are not used because the framework was offered them.
There are ways when the offer becomes invalid however. For example if it is rescinded, in the future it's possible that we're racing with another framework via optimistic offers. In these cases, the behavior will stay consistent with `LaunchTasks`. Currently the master just logs/drops invalid operations.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
-----------------------------------------------------------
On June 26, 2015, 4:54 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 4:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
> The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
> I'll update the guide to accurately reflect the master endpoints as it gets more solified.
> The purpose of including it was/is to get initial feedback on how it generally works.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 79
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line79>
> >
> > A notable difference between static reservation is the principal here, are you going to cover that?
Thanks for bringing this up! I've added the following snippet.
```
We require a `principal` from the operator or framework in order to
authenticate/authorize the operations. [Authorization](authorization.md) is specified via the existing ACL mechanism. (___Coming Soon___)
```
> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 25
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25>
> >
> > existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0?
>
> Michael Park wrote:
> I went with `introduced in 0.14.0` instead.
Actually decided to go with `since 0.14.0`
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
-----------------------------------------------------------
On June 26, 2015, 8:35 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 8:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: [WIP] Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 25
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25>
> >
> > existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0?
I went with `introduced in 0.14.0` instead.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
-----------------------------------------------------------
On June 26, 2015, 3:36 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 3:36 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
> The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
> I'll update the guide to accurately reflect the master endpoints as it gets more solified.
> The purpose of including it was/is to get initial feedback on how it generally works.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
-----------------------------------------------------------
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment133920>
In the following sections
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment133922>
existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0?
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment133924>
A notable difference between static reservation is the principal here, are you going to cover that?
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment133926>
What happens if you try to unreserve a reservation that is being used right now?
- Timothy Chen
On May 8, 2015, 6:57 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 6:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: Do not commit until master API endpoints are implemented for dynamic reservations.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated May 8, 2015, 6:57 p.m.)
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description (updated)
-------
See summary.
NOTE: Do not commit until master API endpoints are implemented for dynamic reservations.
Diffs
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On April 24, 2015, 8:17 a.m., Alexander Rukletsov wrote:
> > LGTM (not a native speaker). Shouldn't we commit this RR after introducing master endpoints : )?
> Shouldn't we commit this RR after introducing master endpoints : )?
Updated the description to make this clear.
> On April 24, 2015, 8:17 a.m., Alexander Rukletsov wrote:
> > docs/reservation.md, lines 97-100
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line97>
> >
> > Do you want to mention HTTP response codes for response?
Yes. Thanks for pointing that out. My plan is to punt the decision to the implementation of master API endpoints.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review81459
-----------------------------------------------------------
On May 8, 2015, 6:57 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 6:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: Do not commit until master API endpoints are implemented for dynamic reservations.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review81459
-----------------------------------------------------------
LGTM (not a native speaker). Shouldn't we commit this RR after introducing master endpoints : )?
docs/reservation.md
<https://reviews.apache.org/r/32982/#comment131849>
Do you want to mention HTTP response codes for response?
- Alexander Rukletsov
On April 8, 2015, 6:41 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 6:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review79436
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32982]
All tests passed.
- Mesos ReviewBot
On April 8, 2015, 6:41 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 6:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>