You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/11 21:37:35 UTC

[GitHub] [tvm] trevor-m opened a new pull request #7253: [BYOC][TRT] Fix weight conversion when first dim of weight shape is 1

trevor-m opened a new pull request #7253:
URL: https://github.com/apache/tvm/pull/7253


   Fixes conversion of weight shape to work with TensorRT's implicit batch dimension. 
   Added test cases which failed before this change.
   Before this PR, a conv2d or dense op which has a kernel weight beginning with 1 (`[1, 32, 3, 3]` or `[1, 128]` for example) would cause an error.
   
   Also, there is an unrelated change to add conv2d_transpose to ConvertLayout list in partition_for_tensorrt.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] trevor-m commented on pull request #7253: [BYOC][TRT] Fix weight conversion when first dim of weight shape is 1

Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #7253:
URL: https://github.com/apache/tvm/pull/7253#issuecomment-758338084


   > LGTM
   
   @comaniac Thanks for the review!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac merged pull request #7253: [BYOC][TRT] Fix weight conversion when first dim of weight shape is 1

Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7253:
URL: https://github.com/apache/tvm/pull/7253


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7253: [BYOC][TRT] Fix weight conversion when first dim of weight shape is 1

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7253:
URL: https://github.com/apache/tvm/pull/7253#issuecomment-759100534


   Thanks @trevor-m 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org