You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by GitBox <gi...@apache.org> on 2021/02/28 15:57:42 UTC
[GitHub] [pdfbox] habbisify opened a new pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
habbisify opened a new pull request #105:
URL: https://github.com/apache/pdfbox/pull/105
Fix the problem described in the issue and add a unit test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] THausherr commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
THausherr commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788111648
@habbisify I have closed the JIRA issue. But your PR was created in good faith and I did review it before looking at the JIRA issue discussion and I would have committed it (with slight changes related to my remark earlier today), so thank you nevertheless.
Please send my greetings to your professor. I like this "homework" idea, you get in touch with open source and go "where it hurts" (in the source code) 😂
I'll also review the other PRs later or tomorrow, they seem good.
Please close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] mkl-public edited a comment on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
mkl-public edited a comment on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788014917
Considering https://github.com/apache/pdfbox/pull/105/commits/e37a62198698f73c400f265ae9b4a480a851f92a - is this some kind of homework?
@THausherr
>Why the `pdfStripper`?
That becomes clear in the intermediary checkin https://github.com/apache/pdfbox/pull/105/commits/ad53c2a1f92f11c85d6cba1076bde49c6bf4f8c7 - a misunderstanding of the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] habbisify commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
habbisify commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788554580
@THausherr Thank you for the effort. I will forward the greetings to the professor!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] THausherr commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
THausherr commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-787778435
Why the `pdfStripper`? Why the change in `PDFontTest.java` (this may be related to a bug that has been fixed)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] habbisify commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
habbisify commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788058662
This PR is related to university course me and the other 3 contributors are taking. Part of it was to create a PR for an open issue in any Apache project which fulfills some criteria - however, acceptance of the PR is not mandatory, fortunately. It seems we went for a questionable issue - should it be closed in Jira? As for now it is still marked as a major, open bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] mkl-public commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
mkl-public commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788001402
As already explained in PDFBOX-4147 itself, the ISO committee responsible showed in the PDF/A specifications that they interpret the PDF specification to allow an `%%EOF` both with and without a following EOL.
Furthermore, there are situations in which an EOL is an advantage, in particular in context of incremental updates.
As there is no issue, therefore, there is nothing to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] mkl-public edited a comment on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
mkl-public edited a comment on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788014917
Considering https://github.com/apache/pdfbox/pull/105/commits/e37a62198698f73c400f265ae9b4a480a851f92a - is this some kind of homework?
@THausherr
>Why the `pdfStripper`?
That becomes clear in the intermediary checkin https://github.com/apache/pdfbox/pull/105/commits/ad53c2a1f92f11c85d6cba1076bde49c6bf4f8c7 - a misunderstanding of the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] habbisify closed pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
habbisify closed pull request #105:
URL: https://github.com/apache/pdfbox/pull/105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] THausherr edited a comment on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
THausherr edited a comment on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-787778435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] mkl-public commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
mkl-public commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788014917
Considering https://github.com/apache/pdfbox/pull/105/commits/e37a62198698f73c400f265ae9b4a480a851f92a - is this some kind of homework?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] mkl-public commented on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
mkl-public commented on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788085837
I'm merely an (active) PDFBox user, not on the PDFBox team itself, so at beast I can advice but neither accept nor reject. So take my words with a grain of salt.
But indeed, in my eyes the issue PDFBOX-4147 should be closed as "not a bug": The PDF/A specifications referencing the PDF specification here clarify how the latter has to be interpreted. And the POSIX reference also points in the same direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] mkl-public edited a comment on pull request #105: PDFBOX-4147 Last PDF line should contain '%%EOF'
Posted by GitBox <gi...@apache.org>.
mkl-public edited a comment on pull request #105:
URL: https://github.com/apache/pdfbox/pull/105#issuecomment-788085837
I'm merely an (active) PDFBox user, not on the PDFBox team itself, so at best I can advice but neither accept nor reject. So take my words with a grain of salt.
But indeed, in my eyes the issue PDFBOX-4147 should be closed as "not a bug": The PDF/A specifications referencing the PDF specification here clarify how the latter has to be interpreted. And the POSIX reference also points in the same direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org