You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/07 07:38:48 UTC

[GitHub] [echarts] 100pah commented on pull request #17155: fix:improve PictorialBarSeriesOption

100pah commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1148309517

   @Ovilia 
   
   > I check the code and the following series don't have SeriesEncodeOptionMixin. @100pah Can you confirm if there are any missing by mistake?
   
   > Treemap
   > Tree
   > Sunburst
   > Lines
   > Graph
   > Sankey
   > ThemeRiver
   > Pictorial (the only one that has encode in the doc)
   
   
   This series theoretically can use `encode`, but seams rarely used? We can probably add `encode` 
   Tree based data source (`Treemap`, `Tree`, `Sunburst`)  and graph based data source (`Graph`, `Sankey `) theoretically can use `encode`, but we might not ready to use it (e.g.,  no test case yet).
   
   `Lines` and `ThemeRiver ` have special data source, which we are not sure whether it is suitable to use `encode` yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org