[GitHub] [arrow] lidavidm commented on pull request #12465: ARROW-15282: [C++][FlightRPC] Split data methods from the underlying transport

[GitBox <gi...@apache.org>]

lidavidm commented on pull request #12465:
URL: https://github.com/apache/arrow/pull/12465#issuecomment-1055581196


   I can try to document it better but effectively the layers are:
   - FlightServerBase: application-facing API that provides overridable methods
   - ServerTransportImpl: transport-facing API that provides an appropriate I/O stream implementation for a given method, and sets up the actual underlying server. Calls into FlightServiceImpl/FlightServerBase
   - FlightServiceImpl: implements application-facing APIs in terms of the transport-facing APIs (effectively, code that is supposed to be transport- and application- agnostic, i.e. "Flight itself")
   
   Ideally transports wouldn't deal with FlightServerBase but I don't want to go through and wrap all the non-data methods quite yet. But effectively, a transport only implements ServerTransportImpl. It's just that the gRPC code is still with the rest of the Flight code; would it be easier if I went ahead and split them out?
   
   FlightService::Serivce/FlightGrpcServiceImpl are gRPC specific


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org