You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/29 08:36:16 UTC
[GitHub] [incubator-seatunnel] hailin0 opened a new pull request, #2950: [Improve][Connector-v2-jdbc] Support for specify number of partitions when parallel reading
hailin0 opened a new pull request, #2950:
URL: https://github.com/apache/incubator-seatunnel/pull/2950
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
example:
e.g: partition_lower_bound = 1, partition_upper_bound = 20
- partition_num = 2
- output:
- partition-1 {start=1, end=10}
- partition-2 {start=11, end=20}
- partition_num = 4
- output:
- partition-1 {start=1, end=5}
- partition-2 {start=6, end=10}
- partition-3 {start11, end=15}
- partition-4 {start=16, end=20}
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2950: [Improve][Connector-v2-jdbc] Support for specify number of partitions when parallel reading
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2950:
URL: https://github.com/apache/incubator-seatunnel/pull/2950#issuecomment-1265427976
@ashulin Is this PR done at the operator level? cc: @hailin0 #2965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2950: [Improve][Connector-v2-jdbc] Support for specify number of partitions when parallel reading
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2950:
URL: https://github.com/apache/incubator-seatunnel/pull/2950#issuecomment-1265452021
> @liugddx partition_num and parallelism are not the same: parallelism defines the number of readers, and partition_num defines the number of splits.
>
> For tables with hundreds of millions of levels, this function is necessary, because the number of readers cannot be expanded indefinitely.
I see. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2950: [Improve][Connector-v2-jdbc] Support for specify number of partitions when parallel reading
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2950:
URL: https://github.com/apache/incubator-seatunnel/pull/2950#issuecomment-1261999535
Can you add test case to prove that `partition_num` can work fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2950: [Improve][Connector-v2-jdbc] Support for specify number of partitions when parallel reading
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2950:
URL: https://github.com/apache/incubator-seatunnel/pull/2950#issuecomment-1265448269
@liugddx partition_num and parallelism are not the same: parallelism defines the number of readers, and partition_num defines the number of splits.
For tables with hundreds of millions of levels, this function is necessary, because the number of readers cannot be expanded indefinitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org