[GitHub] [apisix] dmsolr commented on pull request #6500: fix(tracing): should trace request stopped by extern plugin

[GitBox <gi...@apache.org>]

dmsolr commented on pull request #6500:
URL: https://github.com/apache/apisix/pull/6500#issuecomment-1058748024


   I think finish() should be after `ext-plugin`, but start() should be before `ext-plugin`.
   Moving the finish() to the log phase represents increasing the response time in trace view.
   
   the trace includes 2 spans in APISIX, 
   the first span, entry span, is over the whole request. It means from the request accepted to the response returned.
   the 2nd span, exit span, is only from the sending request to accepting the response.
   （Now, those spans start and stop at the same time.）
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org