[GitHub] andrzej-kaczmarek commented on issue #221: logcfg: Allow logs to be defined in `syscfg.yml`

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on issue #221: logcfg: Allow logs to be defined in `syscfg.yml`
URL: https://github.com/apache/mynewt-newt/pull/221#issuecomment-433097986
 
 
   This is a really nice idea, hopefully someone can review Go code and we can merge this soon :-)
   
   Just few things to consider:
   - what about some "don't care" (`-1`?) module id which means "first available value" (from some predefined range)?
   - this could also generate file with `id` -> `name` mappings so these can be returned by e.g. `newtmgr` and perhaps also used for some pretty-printing later
   - I'm not sure about the `guest` field. perhaps if we want to reuse id of some other module we could have some other field to reference this by name? my concern is that if we change module id of "host" module then it needs to be updated by all "guests"... if we reference by name, this is not a problem.
   
   and I guess eventually we'll be able to remove hardcoded values from `log_common.h` and replace with this new feature?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services