You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "MeMeMax (via GitHub)" <gi...@apache.org> on 2023/05/04 06:25:02 UTC

[GitHub] [echarts] MeMeMax opened a new issue, #18588: [Bug] options defined in replaceMerge are cleared when adding media option

MeMeMax opened a new issue, #18588:
URL: https://github.com/apache/echarts/issues/18588

   ### Version
   
   5.4.2
   
   ### Link to Minimal Reproduction
   
   https://echarts.apache.org/examples/en/editor.html?c=line-smooth&code=PYBwLglsB2DOAEBeeBvAsAKHt7BbApgCYQCGAXPANqY44rwCOArvgE4CeF9uJAHgOoRCYABYUAzAAZJ8AL4AaeKEgwu8AOashasKAnS5hhTVqoTpxiw5rcEaIOFj4UmcawWl4KNDWbtqeF0QCgBWV0UAG3x1fGhCNVgRYAB3CjBWFiNzHFlsgF15bN4AQV4IWC5s7DB2EHwKAHIAYxIwaOAOBsL3WkJW8ioGgFkYLvgGgBUWMYb-IhmJkSYZgDEtGYBlVs2maAa87LdadlLyyp6cGrrGgDcSCOnD7tpYNgh8Cqoqswve_opKABGMKKABMUjBoIALGDAQAORSA8QhRFQgDsYIAbJICt9qrV6uMInZ8A1vrkLgcMLIANyYTCvMATCAEYBMMAACg5AEpEAA-FC4dgAYREJFYYAAdIyAPJeGAc5TeWDyFCsfAgCIkJr4IZsGIAhqvLQfGYlMqwGYnC37WTchRhSTcoA
   
   ### Steps to Reproduce
   
   1. use replaceMerge to set your options like { replaceMerge: ['series'] }
   2. add a media option
   3. chart is not rendered anymore
   
   ### Current Behavior
   
   Chart is not rendered anymore when using replaceMerge (see example)
   
   ### Expected Behavior
   
   Chart should work like without media queries but apply media queries as they fit
   
   ### Environment
   
   ```markdown
   - OS:Windows
   - Browser: Chrome
   - Framework: not relevant
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] options defined in replaceMerge are cleared when adding media option [echarts]

Posted by "clfleury (via GitHub)" <gi...@apache.org>.
clfleury commented on issue #18588:
URL: https://github.com/apache/echarts/issues/18588#issuecomment-2073705871

   > I ran into what I think is similar behavior trying to use `replaceMerge` and it triggered the error ""media" is not valid component main type in "replaceMerge"" from the code below. Is it intended that `replaceMerge` doesn't support `media` or is this a potential bug where media isn't getting registered properly?
   > 
   > https://github.com/apache/echarts/blob/b37d67cbd47534eb3307262d64be9cdae3325609/src/model/Global.ts#L1071-L1075
   
   I run into a similar issue when attempting to use `replaceMerge` with series. I believe it’s tied to the main application’s assigned development environment because it only occurs when I manually set my local environment variable explicitly, and there is an if statement in eCharts that checks if the environment is set to production. Not sure what the utility of the if statement is here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] options defined in replaceMerge are cleared when adding media option [echarts]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18588:
URL: https://github.com/apache/echarts/issues/18588#issuecomment-4361701856

   This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] helgasoft commented on issue #18588: [Bug] options defined in replaceMerge are cleared when adding media option

Posted by "helgasoft (via GitHub)" <gi...@apache.org>.
helgasoft commented on issue #18588:
URL: https://github.com/apache/echarts/issues/18588#issuecomment-1721965968

   >  Is it intended that _replaceMerge_ doesn't support media
   
   [setOption](https://echarts.apache.org/en/api.html#echartsInstance.setOption) and [media.option](https://echarts.apache.org/en/option.html#media.option) are incompatible since both are trying to change the same _option_.
   Interesting to know how developers are planning (or not) to make them work together...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] helgasoft commented on issue #18588: [Bug] options defined in replaceMerge are cleared when adding media option

Posted by "helgasoft (via GitHub)" <gi...@apache.org>.
helgasoft commented on issue #18588:
URL: https://github.com/apache/echarts/issues/18588#issuecomment-1535064019

   :bug: confirmed, _media_ silently crashes _replaceMerge_  - [Demo Code](https://echarts.apache.org/examples/en/editor.html?c=line-simple&code=PYBwLglsB2AEC8sDeAoWsD0HYCcCmAtsAG56wBEAWubAGY7AGwDkBeAJhAIbOxjCwA7hDDQ8AZ3GwARgFcA5mliU2nLgC5YAbSXoksAI6y8OAJ6b9BLgA8A6hHZgAFpoDMABnewAvgBpYuuiwoJAwFrDyOA7h_CBunj7-ADZ48njQ7OHiTsCCmmA4xj6JAUGJgahl6EYm5siwBBDQ9o4usB5efoHoIVDQ4ZHR9bGaAKydyanpmfXZuZq0XEniZN4-gd5KALq-StYAgtYQ4haB7FxgGtrMALIwzP7MACrGDyy2HG_PTrJfAGJRL4AZQuwNk0GYWyUXXQpkOxwsMNgKyiEk0OjKlSq50u6IAjON_AAmDzEokAFmJeIAHP48a5RnTyQB2YkANncO26fFMIDwmmYSSaeDe0C4bAFXFgQrEDw22123gA3CgVmAnhA2MBZGAABS6gCU8AAfMglKAEA1TABhJxcHBgAB0aTAAHlwH1DSqeiBHXCjuItJzHTZjgAZLjSPBJR20GBgD4QeROMCW5jSYBJdjMb3BX3-45BrYhgMRqMxgDGmeAODT-GzuYINrtDsdavdoWgutA_iQ-BASS4FbwNxMaXRzAOAa-BfEXxREAkkO8BpVa18BM8BqAA).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] options defined in replaceMerge are cleared when adding media option [echarts]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18588:
URL: https://github.com/apache/echarts/issues/18588#issuecomment-4316476303

   This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] juliepagano commented on issue #18588: [Bug] options defined in replaceMerge are cleared when adding media option

Posted by "juliepagano (via GitHub)" <gi...@apache.org>.
juliepagano commented on issue #18588:
URL: https://github.com/apache/echarts/issues/18588#issuecomment-1721670117

   I ran into what I think is similar behavior trying to use `replaceMerge` and it triggered the error ""media" is not valid component main type in "replaceMerge"" from the code below. Is it intended that `replaceMerge` doesn't support `media` or is this a potential bug where media isn't getting registered properly?
   
   https://github.com/apache/echarts/blob/b37d67cbd47534eb3307262d64be9cdae3325609/src/model/Global.ts#L1071-L1075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] options defined in replaceMerge are cleared when adding media option [echarts]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #18588: [Bug] options defined in replaceMerge are cleared when adding media option
URL: https://github.com/apache/echarts/issues/18588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org