You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hemanth Yamijala (JIRA)" <ji...@apache.org> on 2008/09/25 13:09:44 UTC
[jira] Created: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
----------------------------------------------------------------------------------------------
Key: HADOOP-4274
URL: https://issues.apache.org/jira/browse/HADOOP-4274
Project: Hadoop Core
Issue Type: Bug
Components: contrib/capacity-sched
Affects Versions: 0.19.0
Reporter: Hemanth Yamijala
Assignee: Hemanth Yamijala
Priority: Blocker
Fix For: 0.19.0
The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634790#action_12634790 ]
Sreekanth Ramakrishnan commented on HADOOP-4274:
------------------------------------------------
Patch seems fine.
+1 for the patch
> Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-4274
> URL: https://issues.apache.org/jira/browse/HADOOP-4274
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4274.patch
>
>
> The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4274:
-------------------------------------
Attachment: HADOOP-4274.patch
Simple patch that addresses the issue. We copy the list of Jobs to a new collection and return that to the caller. Also added a test case that verifies the bug is fixed.
> Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-4274
> URL: https://issues.apache.org/jira/browse/HADOOP-4274
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4274.patch
>
>
> The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4274:
-------------------------------------
Status: Patch Available (was: Open)
> Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-4274
> URL: https://issues.apache.org/jira/browse/HADOOP-4274
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4274.patch
>
>
> The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4274:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Hemanth!
> Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-4274
> URL: https://issues.apache.org/jira/browse/HADOOP-4274
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4274.patch
>
>
> The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634626#action_12634626 ]
Hadoop QA commented on HADOOP-4274:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390929/HADOOP-4274.patch
against trunk revision 698721.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3371/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3371/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3371/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3371/console
This message is automatically generated.
> Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-4274
> URL: https://issues.apache.org/jira/browse/HADOOP-4274
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4274.patch
>
>
> The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4274) Capacity scheduler's implementation
of getJobs modifies the list of running jobs inadvertently
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636031#action_12636031 ]
Hudson commented on HADOOP-4274:
--------------------------------
Integrated in Hadoop-trunk #620 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/620/])
. Capacity scheduler accidently modifies the underlying
data structures when browing the job lists. (Hemanth Yamijala via omalley)
> Capacity scheduler's implementation of getJobs modifies the list of running jobs inadvertently
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-4274
> URL: https://issues.apache.org/jira/browse/HADOOP-4274
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4274.patch
>
>
> The implementation of the {{getJobs}} API gets the running jobs queue from the {{JobQueueManager}}. If it is not null, it appends waiting jobs to the list and returns that. This modifies the original list of running jobs and can affect the scheduler drastically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.