You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/01 07:59:51 UTC
[GitHub] [echarts-doc] ElayGelbart opened a new pull request, #276: feat(graph) full path emphasis.
ElayGelbart opened a new pull request, #276:
URL: https://github.com/apache/echarts-doc/pull/276
* apache/echarts/pull/17451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a diff in pull request #276: feat(graph) full path emphasis.
Posted by GitBox <gi...@apache.org>.
plainheart commented on code in PR #276:
URL: https://github.com/apache/echarts-doc/pull/276#discussion_r1061516045
##########
en/api/events.md:
##########
@@ -235,6 +235,59 @@ Event emitted after range is changed in visualMap.
}
```
+## graphroam(Event)
+Event emitted after [series-graph](option.html#series-graph) is roamed.
Review Comment:
There seem to be some redundant commits, please rebase to the latest dev branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a diff in pull request #276: feat(graph) full path emphasis.
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on code in PR #276:
URL: https://github.com/apache/echarts-doc/pull/276#discussion_r1130773540
##########
en/option/partial/emphasis-common.md:
##########
@@ -40,6 +40,7 @@ When the data is highlighted, whether to fade out of other data to focus the hig
{{ if: ${isGraph} }}
+ `'adjacency'` Focus on the elements of adjacent nodes and edges in the graph.
++ `'trajectory'` Focus on all the elements connected to the node or edge in the graph.
Review Comment:
As per #17451, only the `sankey` series support this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Ovilia commented on a diff in pull request #276: feat(graph) full path emphasis.
Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #276:
URL: https://github.com/apache/echarts-doc/pull/276#discussion_r954739244
##########
en/api/events.md:
##########
@@ -235,6 +235,59 @@ Event emitted after range is changed in visualMap.
}
```
Review Comment:
Please rebase the commit to remove the changes in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart merged pull request #276: feat(sankey): add new strategy `trajectory` for emphasis focus of sankey
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart merged PR #276:
URL: https://github.com/apache/echarts-doc/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a diff in pull request #276: feat(graph) full path emphasis.
Posted by GitBox <gi...@apache.org>.
plainheart commented on code in PR #276:
URL: https://github.com/apache/echarts-doc/pull/276#discussion_r1061516045
##########
en/api/events.md:
##########
@@ -235,6 +235,59 @@ Event emitted after range is changed in visualMap.
}
```
+## graphroam(Event)
+Event emitted after [series-graph](option.html#series-graph) is roamed.
Review Comment:
There seem to be some redundant commits, please rebase to the latest master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a diff in pull request #276: feat(graph) full path emphasis.
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on code in PR #276:
URL: https://github.com/apache/echarts-doc/pull/276#discussion_r1130773540
##########
en/option/partial/emphasis-common.md:
##########
@@ -40,6 +40,7 @@ When the data is highlighted, whether to fade out of other data to focus the hig
{{ if: ${isGraph} }}
+ `'adjacency'` Focus on the elements of adjacent nodes and edges in the graph.
++ `'trajectory'` Focus on all the elements connected to the node or edge in the graph.
Review Comment:
As per apache/echarts#17451, only the `sankey` series support this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org