You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/21 06:13:24 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #357: [YUNIKORN-1038] failure to ignore scheduler pod
wilfred-s opened a new pull request #357:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/357
### What is this PR for?
A missing return causes the admission controller to not ignore the
yunikorn pods. This could cause changes on the yunikorn pod which should
not be made.
### What type of PR is it?
* Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1038
### How should this be tested?
Restart of the scheduler pod with the admission controller running.
Needs manual confirmation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #357: [YUNIKORN-1038] failure to ignore scheduler pod
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #357:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/357#issuecomment-1018217061
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#357](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c93572e) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/406c7ee4c3278699bea8220ec650df52e242604f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (406c7ee) will **not change** coverage.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 62.90% 62.90%
=======================================
Files 41 41
Lines 6104 6104
=======================================
Hits 3840 3840
Misses 2112 2112
Partials 152 152
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `36.90% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [406c7ee...c93572e](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/357?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit closed pull request #357: [YUNIKORN-1038] failure to ignore scheduler pod
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #357:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org