You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Henrik K <he...@hege.li> on 2021/08/03 18:04:39 UTC

Re: svn commit: r1891986 - /spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm

IMO this should really be defined in the plugin itself, especially since
it's a "extra" non-default one that has little to do with the core.

grep "sub has_" Plugins/*


On Tue, Aug 03, 2021 at 04:54:30PM -0000, gbechis@apache.org wrote:
> Author: gbechis
> Date: Tue Aug  3 16:54:30 2021
> New Revision: 1891986
> 
> URL: http://svn.apache.org/viewvc?rev=1891986&view=rev
> Log:
> Add a sub 'feature' for new OLEMacro redirect_uri sub
> 
> Modified:
>     spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm
> 
> Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm?rev=1891986&r1=1891985&r2=1891986&view=diff
> ==============================================================================
> --- spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm (original)
> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm Tue Aug  3 16:54:30 2021
> @@ -5441,6 +5441,7 @@ sub feature_compile_regexp { 1 } # Util:
>  sub feature_meta_rules_matching { 1 } # meta rules_matching() expression
>  sub feature_subjprefix { 1 } # add subject prefixes rule option
>  sub feature_bayes_stopwords { 1 } # multi language stopwords in Bayes
> +sub feature_olemacro_redirect_uri { 1 } # olemacro_redirect_uri implemented in OLEVBMacro plugin
>  sub feature_get_host { 1 } # $pms->get() :host :domain :ip :revip # was implemented together with AskDNS::has_tag_header # Bug 7734
>  sub feature_blocklist_welcomelist { 1 } # bz 7826
>  sub feature_header_address_parser { 1 } # improved header address parsing using Email::Address::XS, $pms->get() list context
> 

Re: svn commit: r1891986 - /spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm

Posted by "Kevin A. McGrail" <km...@apache.org>.
Great! I didn't know we did them in plugins, perfecto!

On 8/3/2021 4:54 PM, Giovanni Bechis wrote:
> Correct,
> I will move the define into the correct place soon.
>   Thanks
>    Giovanni
>
> On 8/3/21 8:04 PM, Henrik K wrote:
>> IMO this should really be defined in the plugin itself, especially since
>> it's a "extra" non-default one that has little to do with the core.
>>
>> grep "sub has_" Plugins/*
>>
>>
>> On Tue, Aug 03, 2021 at 04:54:30PM -0000, gbechis@apache.org wrote:
>>> Author: gbechis
>>> Date: Tue Aug  3 16:54:30 2021
>>> New Revision: 1891986
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1891986&view=rev
>>> Log:
>>> Add a sub 'feature' for new OLEMacro redirect_uri sub
>>>
>>> Modified:
>>>      spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm
>>>
>>> Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm
>>> URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm?rev=1891986&r1=1891985&r2=1891986&view=diff
>>> ==============================================================================
>>> --- spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm (original)
>>> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm Tue Aug  3 16:54:30 2021
>>> @@ -5441,6 +5441,7 @@ sub feature_compile_regexp { 1 } # Util:
>>>   sub feature_meta_rules_matching { 1 } # meta rules_matching() expression
>>>   sub feature_subjprefix { 1 } # add subject prefixes rule option
>>>   sub feature_bayes_stopwords { 1 } # multi language stopwords in Bayes
>>> +sub feature_olemacro_redirect_uri { 1 } # olemacro_redirect_uri implemented in OLEVBMacro plugin
>>>   sub feature_get_host { 1 } # $pms->get() :host :domain :ip :revip # was implemented together with AskDNS::has_tag_header # Bug 7734
>>>   sub feature_blocklist_welcomelist { 1 } # bz 7826
>>>   sub feature_header_address_parser { 1 } # improved header address parsing using Email::Address::XS, $pms->get() list context
>>>
-- 
Kevin A. McGrail
KMcGrail@Apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171


Re: svn commit: r1891986 - /spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm

Posted by Giovanni Bechis <gb...@apache.org>.
Correct,
I will move the define into the correct place soon.
 Thanks
  Giovanni

On 8/3/21 8:04 PM, Henrik K wrote:
> 
> IMO this should really be defined in the plugin itself, especially since
> it's a "extra" non-default one that has little to do with the core.
> 
> grep "sub has_" Plugins/*
> 
> 
> On Tue, Aug 03, 2021 at 04:54:30PM -0000, gbechis@apache.org wrote:
>> Author: gbechis
>> Date: Tue Aug  3 16:54:30 2021
>> New Revision: 1891986
>>
>> URL: http://svn.apache.org/viewvc?rev=1891986&view=rev
>> Log:
>> Add a sub 'feature' for new OLEMacro redirect_uri sub
>>
>> Modified:
>>     spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm
>>
>> Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm
>> URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm?rev=1891986&r1=1891985&r2=1891986&view=diff
>> ==============================================================================
>> --- spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm (original)
>> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Conf.pm Tue Aug  3 16:54:30 2021
>> @@ -5441,6 +5441,7 @@ sub feature_compile_regexp { 1 } # Util:
>>  sub feature_meta_rules_matching { 1 } # meta rules_matching() expression
>>  sub feature_subjprefix { 1 } # add subject prefixes rule option
>>  sub feature_bayes_stopwords { 1 } # multi language stopwords in Bayes
>> +sub feature_olemacro_redirect_uri { 1 } # olemacro_redirect_uri implemented in OLEVBMacro plugin
>>  sub feature_get_host { 1 } # $pms->get() :host :domain :ip :revip # was implemented together with AskDNS::has_tag_header # Bug 7734
>>  sub feature_blocklist_welcomelist { 1 } # bz 7826
>>  sub feature_header_address_parser { 1 } # improved header address parsing using Email::Address::XS, $pms->get() list context
>>