[jira] [Work logged] (GOBBLIN-1336) Implement a streaming version of TimePartitionedDataPublisher

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1336?focusedWorklogId=545504&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545504 ]

ASF GitHub Bot logged work on GOBBLIN-1336:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Feb/21 18:38
            Start Date: 01/Feb/21 18:38
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on a change in pull request #3173:
URL: https://github.com/apache/incubator-gobblin/pull/3173#discussion_r568051815



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/publisher/TimePartitionedStreamingDataPublisher.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.publisher;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Map;
+import java.util.Set;
+
+import org.apache.hadoop.fs.Path;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.State;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.instrumented.Instrumented;
+import org.apache.gobblin.metrics.MetricContext;
+import org.apache.gobblin.metrics.event.lineage.LineageInfo;
+import org.apache.gobblin.util.ForkOperatorUtils;
+import org.apache.gobblin.util.ParallelRunner;
+import org.apache.gobblin.util.WriterUtils;
+
+
+@Slf4j
+public class TimePartitionedStreamingDataPublisher extends TimePartitionedDataPublisher {
+  private final MetricContext metricContext;
+  public TimePartitionedStreamingDataPublisher(State state) throws IOException {
+    super(state);
+    this.metricContext = Instrumented.getMetricContext(state, TimePartitionedStreamingDataPublisher.class);
+  }
+
+  /**
+   * This method publishes task output data for the given {@link WorkUnitState}, but if there are output data of
+   * other tasks in the same folder, it may also publish those data.
+   */
+  protected void publishMultiTaskData(WorkUnitState state, int branchId, Set<Path> writerOutputPathsMoved)
+      throws IOException {

Review comment:
       Addressed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 545504)
    Time Spent: 50m  (was: 40m)

> Implement a streaming version of TimePartitionedDataPublisher
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-1336
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1336
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-core
>    Affects Versions: 0.16.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Abhishek Tiwari
>            Priority: Major
>             Fix For: 0.16.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> A TimePartitionedDataPublisher that is intended for streaming mode of execution. This data publisher performs a state clean up on each publish action. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)