You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by harrison-tarr <gi...@git.apache.org> on 2018/05/09 19:18:16 UTC

[GitHub] felix pull request #136: Add better support for backslashes in read

GitHub user harrison-tarr opened a pull request:

    https://github.com/apache/felix/pull/136

    Add better support for backslashes in read

    I noticed an issue where when I included backslashes in my configuration, Felix would basically eat those backslashes. 
    eg. `fileRoot="\\127.0.0.1\some\file\path\"` would become `fileRoot="127.0.0.1some\filepath\""`
    I was able to write some unit tests to reproduce this issue. My changes that I introduced to the `ConfigurationHandler` still pass the rest of the unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/harrison-tarr/felix windows-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/felix/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit 6c628022b1d4fd813f61e055efa21bb34eb69e7b
Author: Harrison Tarr <ha...@...>
Date:   2018-05-09T19:15:33Z

    Add better support for backslashes in read

----


---