You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2023/03/14 09:57:38 UTC

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19618


Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................

IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

This patch fixes the BetweenToCompound rewrite rule's binary predicate
creation. When the BETWEEN expression get separated, the first operand's
reference is assigned to both upper and lower binary predicates, but in
the case of different typed second and third operands, the first operand
must be cloned to make type casting unique for both binary predicates.

Testing:
  - test case added to exprs.test

Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
---
M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 32 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/19618/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12658/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 13:02:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 20:01:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 14:47:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19618/3/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/19618/3/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@46
PS3, Line 46:     Expr clonedValue = value.clone();
            :     Expr lowerBound = bp.getChild(1);
            :     Expr upperBound = bp.getChild(2);
            : 
            :     BinaryPredicate.Operator lowerOperator;
            :     BinaryPredicate.Operator upperOperator;
            :     CompoundPredicate.Operator compoundOperator;
I am not sure if this refactor made things easier to understand, but it is ok if you prefer it this way.



-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 14:10:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19618/3/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/19618/3/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@46
PS3, Line 46:     Expr clonedValue = value.clone();
            :     Expr lowerBound = bp.getChild(1);
            :     Expr upperBound = bp.getChild(2);
            : 
            :     BinaryPredicate.Operator lowerOperator;
            :     BinaryPredicate.Operator upperOperator;
            :     CompoundPredicate.Operator compoundOperator;
> I am not sure if this refactor made things easier to understand, but it is 
I would prefer this approach, as Daniel already assisted in making it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 14:42:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................

IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

This patch fixes the BetweenToCompound rewrite rule's binary predicate
creation. When the BETWEEN expression gets separated, the first
operand's
reference is assigned to both upper and lower binary predicates, but in
the case of different typed second and third operands, the first operand
must be cloned to make type casting unique for both binary predicates.

Testing:
  - test case added to exprs.test

Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
---
M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 92 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/19618/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................

IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

This patch fixes the BetweenToCompound rewrite rule's binary predicate
creation. When the BETWEEN expression gets separated, the first
operand's reference is assigned to both upper and lower binary
predicates, but in the case of different typed second and third
operands, the first operand must be cloned to make type casting unique
for both binary predicates.

Testing:
  - test cases added to exprs.test

Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Reviewed-on: http://gerrit.cloudera.org:8080/19618
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 92 insertions(+), 13 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/19618/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19618/1//COMMIT_MSG@10
PS1, Line 10: get
Nit: gets


http://gerrit.cloudera.org:8080/#/c/19618/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/19618/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@44
PS1, Line 44:     Expr left = bp.getChild(0);
We should use more descriptive names for these variables: 'middle' could be 'lowerBound', 'right' could be 'upperBound'. I don't have a good name for 'left', it could be 'value'.


http://gerrit.cloudera.org:8080/#/c/19618/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@48
PS1, Line 48:     BinaryPredicate.Operator lowerOperator = BinaryPredicate.Operator.GE;
Having an IF branch for disjunction and another for conjunction is in my opinion more readable than extracting the operators, but I understand that you wanted to extract the common parts. If it is the cloning that you didn't want to repeat, you could create the clone before the IF and use the cloned value for the second predicate in each branch.


http://gerrit.cloudera.org:8080/#/c/19618/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@52
PS1, Line 52:     if (bp.isNotBetween()) {
In my opinion it would be cleaner if we first declared these variables without defining them and then put the definitions into the two branches of an if - else statement.


http://gerrit.cloudera.org:8080/#/c/19618/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@60
PS1, Line 60: left.clone()
Optional: it only necessary to clone it if the type of the other two operands is different, but it may not be worth the effort to determine if that is the case.


http://gerrit.cloudera.org:8080/#/c/19618/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

http://gerrit.cloudera.org:8080/#/c/19618/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3218
PS1, Line 3218: ====
We could also have a test with "NOT BETWEEN", as well as tests involving NULLs.



-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 14:56:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12656/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 10:29:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12622/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 10:18:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19618/3/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/19618/3/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@46
PS3, Line 46:     Expr clonedValue = value.clone();
            :     Expr lowerBound = bp.getChild(1);
            :     Expr upperBound = bp.getChild(2);
            : 
            :     BinaryPredicate.Operator lowerOperator;
            :     BinaryPredicate.Operator upperOperator;
            :     CompoundPredicate.Operator compoundOperator;
> I would prefer this approach, as Daniel already assisted in making it.
ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 14:46:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19618/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19618/2//COMMIT_MSG@11
PS2, Line 11: operand's
Nit: unnecessary newline.


http://gerrit.cloudera.org:8080/#/c/19618/2/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/19618/2/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@44
PS2, Line 44: avoid changes
Nit: "avoid being affected by changes" would be clearer.



-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 11:22:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 12:46:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9162/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 14:47:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................

IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

This patch fixes the BetweenToCompound rewrite rule's binary predicate
creation. When the BETWEEN expression gets separated, the first
operand's reference is assigned to both upper and lower binary
predicates, but in the case of different typed second and third
operands, the first operand must be cloned to make type casting unique
for both binary predicates.

Testing:
  - test cases added to exprs.test

Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
---
M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 92 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/19618/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19618 )

Change subject: IMPALA-8054: Fix BetweenToCompound rewrite rule binary predicate creation
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19618/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19618/2//COMMIT_MSG@11
PS2, Line 11: operand's reference is assigned to both upper and lower binary
> Nit: unnecessary newline.
Done


http://gerrit.cloudera.org:8080/#/c/19618/2/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/19618/2/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@44
PS2, Line 44: o avoid being
> Nit: "avoid being affected by changes" would be clearer.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff4199f6d0875c38fa7e91033385c9290c57bf5
Gerrit-Change-Number: 19618
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Mar 2023 12:39:15 +0000
Gerrit-HasComments: Yes