You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/10 14:52:40 UTC

[lucy-issues] [jira] [Commented] (CLOWNFISH-36) Handle circular references in Perl array and hash conversion

    [ https://issues.apache.org/jira/browse/CLOWNFISH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189309#comment-15189309 ] 

ASF GitHub Bot commented on CLOWNFISH-36:
-----------------------------------------

GitHub user nwellnhof opened a pull request:

    https://github.com/apache/lucy-clownfish/pull/62

    Check for circular references in Perl array and hash conversion

    Fixes CLOWNFISH-36.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nwellnhof/lucy-clownfish circular-refs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy-clownfish/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----
commit 6c8dbb36de4171950264c54ea813f1bba275bc61
Author: Nick Wellnhofer <we...@aevum.de>
Date:   2016-03-08T10:54:30Z

    Implement pointer-to-pointer hash table

commit 3e0546fabc8a2c3953561e184fc3bc5d2a10a8f1
Author: Nick Wellnhofer <we...@aevum.de>
Date:   2016-03-08T10:54:42Z

    Handle circular refs when converting from Perl
    
    First half of CLOWNFISH-36.

commit f3eea9b22fef28df418cc4f71f861d9c7f2ab3d8
Author: Nick Wellnhofer <we...@aevum.de>
Date:   2016-03-08T10:54:47Z

    Add extra parameter to Obj_To_Host
    
    This parameter will be used to pass the conversion cache around.

commit d9829fb0dfdfbedc39463d19e2d1958d9a84593d
Author: Nick Wellnhofer <we...@aevum.de>
Date:   2016-03-08T10:54:53Z

    Handle circular refs when converting to Perl
    
    Also check for I32 overflow when converting Vector to AV.
    
    Second half of CLOWNFISH-36.

----


> Handle circular references in Perl array and hash conversion
> ------------------------------------------------------------
>
>                 Key: CLOWNFISH-36
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-36
>             Project: Apache Lucy-Clownfish
>          Issue Type: Bug
>          Components: Perl
>            Reporter: Nick Wellnhofer
>            Assignee: Nick Wellnhofer
>
> When converting arrays and hashes between Clownfish and Perl, circular references should be detected and handled properly. The current implementation may loop infinitely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)