[GitHub] [cordova-plugin-media] AgDude commented on a change in pull request #249: Fix #248 delete javascript reference to released media

[GitBox <gi...@apache.org>]

AgDude commented on a change in pull request #249: Fix #248 delete javascript reference to released media
URL: https://github.com/apache/cordova-plugin-media/pull/249#discussion_r403189006
 
 

 ##########
 File path: www/Media.js
 ##########
 @@ -156,7 +156,10 @@ Media.prototype.resumeRecord = function() {
  * Release the resources.
  */
 Media.prototype.release = function() {
-    exec(null, this.errorCallback, "Media", "release", [this.id]);
+    var me = this;
+    exec(function() {
+      delete mediaObjects[me.id];
 
 Review comment:
   `mediaObjects` is an object, not an array. It is defined on line 26.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org