You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/27 14:29:18 UTC
[GitHub] [flink] fapaul opened a new pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
fapaul opened a new pull request #17580:
URL: https://github.com/apache/flink/pull/17580
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Before this change, Flink's configuration where not passed to the
filesytems if used in LocalStreamEnvironment. This may lead to i.e.
missing credentials. This change initializes the filesytems through the
pluginloader which forwards the configuration as it is done when
running a real cluster.
## Brief change log
Build the pluginloader in the Minicluster and initialize the filesystems with it.
## Verifying this change
- Added a test to verify that the configuration is available within the filesystem while running in the LocalStreamEnvironment
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741699912
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
I don't think so because all tests using the `MiniClusters` implicitly go through the `LocalEnvironment.`
While it is true that users cannot set credentials via the configuration passed to the environment, they could call `FileSystem#initialize()` themselves.
Yes, it is surprising and not ergonomic and all that.
Alternatively we would need a way to reset the `FileSystem` (i.e., call initialize again with no configuration) after each test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "958712175",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740026900
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
The filesystems are initialized anyways but if we do not load them through the pluginloader the configuration is not passed to them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740028243
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
Review comment:
How would I pass the `SharedReference` to the filesystem since it is loaded through SPI? So far I only used `SharedReference` for cases where I could somehow inject the variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741716802
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Yes, but users are trying out their Flink job locally and use a `plugin` folder in their working directories for s3 (that works by default).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741723058
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Just from the last month: https://lists.apache.org/thread/kojvkx9ops9fmdkkcwsmpzkwrx94wcym https://lists.apache.org/thread/2dnlk7lc489ts20338cl3ll8gvfx6f21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "958712175",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82f7380098b37be3273c3df0c2ffd5aa50f34e3d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577)
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741708249
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Filesystems can still be loaded through the FileSystemFactory service if they are on the classpath.
Plugins in local environments are a bit eh because there's a) no sane way to control the plugin directory (no, setting some internal env variable is not sane) and b) you must not add a `dependency` on said FS otherwise you lose all the benefits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbad41f143a5ecba2fb866a6bbbfb49ca5592da0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526)
* 82f7380098b37be3273c3df0c2ffd5aa50f34e3d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741004140
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
> Is MiniCluster always and only used for LocalExecutionEnvironment?
No. It can also be used if the Test(Stream)Environments are explicitly set by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741067353
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
The `FileSystem#initialize(Configuration)` method is marked as deprecated I did not want to add a usage again.
##########
File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.client.ExecutionEnvironmentTest$TestFileSystemFactoryWithConfiguration
Review comment:
Thanks for the hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbad41f143a5ecba2fb866a6bbbfb49ca5592da0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741067353
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
The `FileSystem#initialize(Configuration)` method is marked as deprecated I did not want to add a usage again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741004140
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
> Is MiniCluster always and only used for LocalExecutionEnvironment?
No. It can also be used if the Test(Stream)Environments are explicitly set by the user.
##########
File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.client.ExecutionEnvironmentTest$TestFileSystemFactoryWithConfiguration
Review comment:
Consider using the `ContextClassLoaderExtension` to prevent this service entry from polluting the logs of other tests.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
This pretty much doesn't do anything so I'd suggest to use `FileSystem#initialize(Configuration).`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
This seems sketchy. Because `FileSystem` is partially a singleton this could have surprising effects on other tests if a FS is provided for one of the default schemes (e.g., a custom LocalFileSystem).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
The ClusterEntryPoint is used for actual clusters where the TMs run externally. The MiniCluster is the single-JVM equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741697624
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
then you can also pass null for the PluginManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741705400
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
How about we add a test-only `uninitialize`? Wouldn't that be the cleanest option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r743695325
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Tests might not explicitly call initialize; if they have a factory on the CP then it is loaded implicitly on first use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740024899
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
Review comment:
It is not about the cast but rather the execution, without inserting the mapper the job is not executable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741004140
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
> Is MiniCluster always and only used for LocalExecutionEnvironment?
No. It can also be used if the Test(Stream)Environments are explicitly set by the user.
##########
File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.client.ExecutionEnvironmentTest$TestFileSystemFactoryWithConfiguration
Review comment:
Consider using the `ContextClassLoaderExtension` to prevent this service entry from polluting the logs of other tests.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
This pretty much doesn't do anything so I'd suggest to use `FileSystem#initialize(Configuration).`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
This seems sketchy. Because `FileSystem` is partially a singleton this could have surprising effects on other tests if a FS is provided for one of the default schemes (e.g., a custom LocalFileSystem).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
The ClusterEntryPoint is used for actual clusters where the TMs run externally. The MiniCluster is the single-JVM equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741708843
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
And who calls that? Every test that uses a filesystem? Every test that does something special? How do you enforce that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-958712175
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-958712175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "958712175",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "958712175",
"triggerType" : "MANUAL"
}, {
"hash" : "f8a65a031b6ab973aa78ae41745621b8257da6a4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26225",
"triggerID" : "f8a65a031b6ab973aa78ae41745621b8257da6a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f8a65a031b6ab973aa78ae41745621b8257da6a4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-958712175
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741062579
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Would it be safer to move it to the `LocalExecutor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741018922
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
This pretty much doesn't do anything so I'd suggest to use `FileSystem#initialize(Configuration).`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
This seems sketchy. Because `FileSystem` is partially a singleton this could have surprising effects on other tests if a FS is provided for one of the default schemes (e.g., a custom LocalFileSystem).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
The ClusterEntryPoint is used for actual clusters where the TMs run externally. The MiniCluster is the single-JVM equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r738310788
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
Review comment:
This piece is a bit unfortunate but I didn't see another way how to structure the tests that other tests are not affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r743695325
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Tests might not explicitly call initialize; if they have a factory on the CP then it is loaded implicitly on first use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r755791294
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -120,12 +125,20 @@
import java.util.function.Function;
import java.util.stream.Collectors;
+import static org.apache.flink.configuration.ConfigOptions.key;
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.apache.flink.util.Preconditions.checkState;
/** MiniCluster to execute Flink jobs locally. */
public class MiniCluster implements AutoCloseableAsync {
+ public static final ConfigOption<String> PLUGIN_DIRECTORY =
Review comment:
Do we need a config option here? I was thinking that it would be better in this case to add a simple `String` field to `MiniClusterConfiguration` iff the option is only ever used in the `MiniCluster`. Then we can make it easier to use in `MiniClusterConfiguration#Builder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbad41f143a5ecba2fb866a6bbbfb49ca5592da0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r764077522
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -120,12 +125,20 @@
import java.util.function.Function;
import java.util.stream.Collectors;
+import static org.apache.flink.configuration.ConfigOptions.key;
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.apache.flink.util.Preconditions.checkState;
/** MiniCluster to execute Flink jobs locally. */
public class MiniCluster implements AutoCloseableAsync {
+ public static final ConfigOption<String> PLUGIN_DIRECTORY =
Review comment:
If you want to support `LocalExecutionEnvironment` then, we should move the options to somewhere more visible. Then the question arises why we are not supporting all envs ;).
Or we just say that for `MiniCluster` that we just use `MiniClusterConfiguration` and for everything else we use the `ENV_FLINK_PLUGINS_DIR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741702581
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Why is `null` sufficient? I think the `pluginManager` is needed such that files in the plugin folder are loaded at all. That's the only way to read/write to S3 in local setup. I'm probably missing something here.
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Btw same question as below: have we actually initialized plugins before your fix at all? I don't think so.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
How about we add a test-only `uninitialize`? Wouldn't that be the cleanest option?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Every test that calls `initialize` must call `uninitialize`. We can't enforce it but rather make sure that all existing tests are abiding it.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Yes, but users are trying out their Flink job locally and use a `plugin` folder in their working directories for s3 (that works by default).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Just from the last month: https://lists.apache.org/thread/kojvkx9ops9fmdkkcwsmpzkwrx94wcym https://lists.apache.org/thread/2dnlk7lc489ts20338cl3ll8gvfx6f21
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Why is `null` sufficient? I think the `pluginManager` is needed such that files in the plugin folder are loaded at all. That's the only way to read/write to S3 in local setup. I'm probably missing something here.
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Btw same question as below: have we actually initialized plugins before your fix at all? I don't think so.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
How about we add a test-only `uninitialize`? Wouldn't that be the cleanest option?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Every test that calls `initialize` must call `uninitialize`. We can't enforce it but rather make sure that all existing tests are abiding it.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Yes, but users are trying out their Flink job locally and use a `plugin` folder in their working directories for s3 (that works by default).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Just from the last month: https://lists.apache.org/thread/kojvkx9ops9fmdkkcwsmpzkwrx94wcym https://lists.apache.org/thread/2dnlk7lc489ts20338cl3ll8gvfx6f21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741702581
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Why is `null` sufficient? I think the `pluginManager` is needed such that files in the plugin folder are loaded at all. That's the only way to read/write to S3 in local setup. I'm probably missing something here.
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Btw same question as below: have we actually initialized plugins before your fix at all? I don't think so.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
How about we add a test-only `uninitialize`? Wouldn't that be the cleanest option?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Every test that calls `initialize` must call `uninitialize`. We can't enforce it but rather make sure that all existing tests are abiding it.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Yes, but users are trying out their Flink job locally and use a `plugin` folder in their working directories for s3 (that works by default).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Just from the last month: https://lists.apache.org/thread/kojvkx9ops9fmdkkcwsmpzkwrx94wcym https://lists.apache.org/thread/2dnlk7lc489ts20338cl3ll8gvfx6f21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741254958
##########
File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.client.ExecutionEnvironmentTest$TestFileSystemFactoryWithConfiguration
Review comment:
Thanks for the hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbad41f143a5ecba2fb866a6bbbfb49ca5592da0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526)
* 82f7380098b37be3273c3df0c2ffd5aa50f34e3d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r743695325
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Tests might not explicitly call initialize; if they have a factory on the CP then it is loaded implicitly on first use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741062579
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Would it be safer to move it to the `LocalExecutor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740032009
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
+ environment.execute("configureFilesystem");
+ expectConfiguration = false;
+ }
+
private void testJobName(String prefixOfExpectedJobName, ExecutionEnvironment env) {
env.fromElements(1, 2, 3).writeAsText("/dev/null");
Plan plan = env.createProgramPlan();
assertTrue(plan.getJobName().startsWith(prefixOfExpectedJobName));
}
+
+ /** Test filesystem to check that configurations are propagated. */
+ public static final class TestFileSystemFactoryWithConfiguration
+ extends TestFileSystem.TestFileSystemFactory {
+
+ @Override
+ public String getScheme() {
+ return "testConfig";
+ }
+
+ @Override
+ public void configure(Configuration config) {
+ if (!expectConfiguration) {
+ return;
+ }
+ EXPECTED_CONFIGURATION.forEach((k, v) -> assertEquals(v, config.getString(k, null)));
Review comment:
Sorry but what exactly do you want to see here? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740481614
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
+ environment.execute("configureFilesystem");
+ expectConfiguration = false;
+ }
+
private void testJobName(String prefixOfExpectedJobName, ExecutionEnvironment env) {
env.fromElements(1, 2, 3).writeAsText("/dev/null");
Plan plan = env.createProgramPlan();
assertTrue(plan.getJobName().startsWith(prefixOfExpectedJobName));
}
+
+ /** Test filesystem to check that configurations are propagated. */
+ public static final class TestFileSystemFactoryWithConfiguration
+ extends TestFileSystem.TestFileSystemFactory {
+
+ @Override
+ public String getScheme() {
+ return "testConfig";
+ }
+
+ @Override
+ public void configure(Configuration config) {
+ if (!expectConfiguration) {
+ return;
+ }
+ EXPECTED_CONFIGURATION.forEach((k, v) -> assertEquals(v, config.getString(k, null)));
Review comment:
```
assertEquals(v, config.getString(k, null), "Unexpected config entry for " + k)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740480590
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Hm, we should probably remove the fallback and fail hard to exactly find these kind of issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "958712175",
"triggerType" : "MANUAL"
}, {
"hash" : "f8a65a031b6ab973aa78ae41745621b8257da6a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f8a65a031b6ab973aa78ae41745621b8257da6a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
* f8a65a031b6ab973aa78ae41745621b8257da6a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741702581
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Why is `null` sufficient? I think the `pluginManager` is needed such that files in the plugin folder are loaded at all. That's the only way to read/write to S3 in local setup. I'm probably missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r764073592
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -120,12 +125,20 @@
import java.util.function.Function;
import java.util.stream.Collectors;
+import static org.apache.flink.configuration.ConfigOptions.key;
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.apache.flink.util.Preconditions.checkState;
/** MiniCluster to execute Flink jobs locally. */
public class MiniCluster implements AutoCloseableAsync {
+ public static final ConfigOption<String> PLUGIN_DIRECTORY =
Review comment:
I think this depends a bit if a user only wants to execute a jar locally. In this case one usually does not interact with the minicluster it is only started in the background by the `LocalExecutionEnvironment`.
Perhaps one option can be to offer both possibilities but this may also confuse users. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741005171
##########
File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.client.ExecutionEnvironmentTest$TestFileSystemFactoryWithConfiguration
Review comment:
Consider using the `ContextClassLoaderExtension` to prevent this service entry from polluting the logs of other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740480590
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Hm, we should probably remove the fallback and fail hard to exactly find these kind of issues.
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
Review comment:
Fair point.
On a related note: Does that configuration really need to be volatile?
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
+ environment.execute("configureFilesystem");
+ expectConfiguration = false;
+ }
+
private void testJobName(String prefixOfExpectedJobName, ExecutionEnvironment env) {
env.fromElements(1, 2, 3).writeAsText("/dev/null");
Plan plan = env.createProgramPlan();
assertTrue(plan.getJobName().startsWith(prefixOfExpectedJobName));
}
+
+ /** Test filesystem to check that configurations are propagated. */
+ public static final class TestFileSystemFactoryWithConfiguration
+ extends TestFileSystem.TestFileSystemFactory {
+
+ @Override
+ public String getScheme() {
+ return "testConfig";
+ }
+
+ @Override
+ public void configure(Configuration config) {
+ if (!expectConfiguration) {
+ return;
+ }
+ EXPECTED_CONFIGURATION.forEach((k, v) -> assertEquals(v, config.getString(k, null)));
Review comment:
```
assertEquals(v, config.getString(k, null), "Unexpected config entry for " + k)
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Would it be safer to move it to the `LocalExecutor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741697624
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
then you can also pass null for the PluginManager.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
I don't think so because all tests using the `MiniClusters` implicitly go through the `LocalEnvironment.`
While it is true that users cannot set credentials via the configuration passed to the environment, they could call `FileSystem#initialize()` themselves.
Yes, it is surprising and not ergonomic and all that.
Alternatively we would need a way to reset the `FileSystem` (i.e., call initialize again with no configuration) after each test.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Filesystems can still be loaded through the FileSystemFactory service if they are on the classpath.
Plugins in local environments are a bit eh because there's a) no sane way to control the plugin directory (no, setting some internal env variable is not sane) and b) you must not add a `dependency` on said FS otherwise you lose all the benefits.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
And who calls that? Every test that uses a filesystem? Every test that does something special? How do you enforce that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741697624
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
then you can also pass null for the PluginManager.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
I don't think so because all tests using the `MiniClusters` implicitly go through the `LocalEnvironment.`
While it is true that users cannot set credentials via the configuration passed to the environment, they could call `FileSystem#initialize()` themselves.
Yes, it is surprising and not ergonomic and all that.
Alternatively we would need a way to reset the `FileSystem` (i.e., call initialize again with no configuration) after each test.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Filesystems can still be loaded through the FileSystemFactory service if they are on the classpath.
Plugins in local environments are a bit eh because there's a) no sane way to control the plugin directory (no, setting some internal env variable is not sane) and b) you must not add a `dependency` on said FS otherwise you lose all the benefits.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
And who calls that? Every test that uses a filesystem? Every test that does something special? How do you enforce that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82f7380098b37be3273c3df0c2ffd5aa50f34e3d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
* 21df3dcb1c0cb988e435df053c93af65d65852b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817)
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741067353
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
The `FileSystem#initialize(Configuration)` method is marked as deprecated I did not want to add a usage again.
##########
File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.client.ExecutionEnvironmentTest$TestFileSystemFactoryWithConfiguration
Review comment:
Thanks for the hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82f7380098b37be3273c3df0c2ffd5aa50f34e3d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577)
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740481145
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
Review comment:
Fair point.
On a related note: Does that configuration really need to be volatile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741716048
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
Every test that calls `initialize` must call `uninitialize`. We can't enforce it but rather make sure that all existing tests are abiding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r740017920
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
Review comment:
Can't you use `SharedReference` here?
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
+ environment.execute("configureFilesystem");
+ expectConfiguration = false;
+ }
+
private void testJobName(String prefixOfExpectedJobName, ExecutionEnvironment env) {
env.fromElements(1, 2, 3).writeAsText("/dev/null");
Plan plan = env.createProgramPlan();
assertTrue(plan.getJobName().startsWith(prefixOfExpectedJobName));
}
+
+ /** Test filesystem to check that configurations are propagated. */
+ public static final class TestFileSystemFactoryWithConfiguration
+ extends TestFileSystem.TestFileSystemFactory {
Review comment:
I probably wouldn't inherit here but just create the factory from scratch. You are only saving one method here but have more interdependence.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
+
Review comment:
Is `MiniCluster` always and only used for `LocalExecutionEnvironment`? I think the fix is legit but I'm wondering if the description is accurate. Are we solving an issue in the `LocalExecutor` or in `MiniCluster`?
I also don't quite understand why `ClusterEntrypoint` is not used at all in `LocalExecutionEnvironment`. @zentol could you please also have peek?
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
+ // We only want to enable the configuration check for this test case. Nevertheless, the
+ // filesystem is loaded and configured for all test cases in this module.
+ expectConfiguration = true;
+ environment.execute("configureFilesystem");
+ expectConfiguration = false;
+ }
+
private void testJobName(String prefixOfExpectedJobName, ExecutionEnvironment env) {
env.fromElements(1, 2, 3).writeAsText("/dev/null");
Plan plan = env.createProgramPlan();
assertTrue(plan.getJobName().startsWith(prefixOfExpectedJobName));
}
+
+ /** Test filesystem to check that configurations are propagated. */
+ public static final class TestFileSystemFactoryWithConfiguration
+ extends TestFileSystem.TestFileSystemFactory {
+
+ @Override
+ public String getScheme() {
+ return "testConfig";
+ }
+
+ @Override
+ public void configure(Configuration config) {
+ if (!expectConfiguration) {
+ return;
+ }
+ EXPECTED_CONFIGURATION.forEach((k, v) -> assertEquals(v, config.getString(k, null)));
Review comment:
Use assertion string.
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -91,9 +106,42 @@ public void testUserDefinedJobNameWithConfigure() {
testJobName(jobName, env);
}
+ @Test
+ public void testConfigureFileSystem() throws Exception {
+ final Configuration config = new Configuration();
+ EXPECTED_CONFIGURATION.forEach(config::setString);
+ final StreamExecutionEnvironment environment = new LocalStreamEnvironment(config);
+ environment.getCheckpointConfig().setCheckpointStorage("testConfig:/" + tmp.newFolder());
+ environment.enableCheckpointing(100);
+ environment.fromElements(1, 2, 3, 4).map((MapFunction<Integer, Integer>) value -> value);
Review comment:
Is this cast needed?
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Commit + PR message should rather read: `Initialize filesystems when run in LocalStreamEnvironment`.
The issue is not that configuration was incorrectly passed to the fs but rather that plugins where not initialized at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741703527
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ExecutionEnvironmentTest.java
##########
@@ -26,13 +26,22 @@
import org.apache.flink.api.java.io.DiscardingOutputFormat;
Review comment:
Btw same question as below: have we actually initialized plugins before your fix at all? I don't think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741697624
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
then you can also pass null for the PluginManager.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
I don't think so because all tests using the `MiniClusters` implicitly go through the `LocalEnvironment.`
While it is true that users cannot set credentials via the configuration passed to the environment, they could call `FileSystem#initialize()` themselves.
Yes, it is surprising and not ergonomic and all that.
Alternatively we would need a way to reset the `FileSystem` (i.e., call initialize again with no configuration) after each test.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Filesystems can still be loaded through the FileSystemFactory service if they are on the classpath.
Plugins in local environments are a bit eh because there's a) no sane way to control the plugin directory (no, setting some internal env variable is not sane) and b) you must not add a `dependency` on said FS otherwise you lose all the benefits.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() == RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+ PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
And who calls that? Every test that uses a filesystem? Every test that does something special? How do you enforce that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25526",
"triggerID" : "bbad41f143a5ecba2fb866a6bbbfb49ca5592da0",
"triggerType" : "PUSH"
}, {
"hash" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25577",
"triggerID" : "82f7380098b37be3273c3df0c2ffd5aa50f34e3d",
"triggerType" : "PUSH"
}, {
"hash" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25733",
"triggerID" : "501c93d6fb01c5a757d5ee0cf5d77705faa80727",
"triggerType" : "PUSH"
}, {
"hash" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25817",
"triggerID" : "21df3dcb1c0cb988e435df053c93af65d65852b5",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"triggerType" : "PUSH"
}, {
"hash" : "d1682e703b0b8c83740148f684a8bc3d55c0f7f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821",
"triggerID" : "958712175",
"triggerType" : "MANUAL"
}, {
"hash" : "f8a65a031b6ab973aa78ae41745621b8257da6a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26225",
"triggerID" : "f8a65a031b6ab973aa78ae41745621b8257da6a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1682e703b0b8c83740148f684a8bc3d55c0f7f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25821)
* f8a65a031b6ab973aa78ae41745621b8257da6a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org