You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jack Moffitt <ja...@xiph.org> on 2003/07/23 06:02:11 UTC
cvs2svn.py: two more bugs and test repositories
Ok, I've finally narrowed down the "finishing tag 'start'" problem to a
4MB repository with about 4-5 modules. Removing anything eliminates the
error or causes a different one.
Running 'cvs2svn.py -v --dump-only testrepo-tag' fails with:
File "../cvs2svn/cvs2svn.py", line 983, in copy_path entries)
File "../cvs2svn/cvs2svn.py", line 673, in change_path
approved_entries = new_val.get(self.approved_entries)
AttributeError: 'NoneType' object has no attribute 'get'
It looks it is tripping over the same thing as Bug #1417, just from a
different code path.
Also note that the reproduction data is very senstive to being messed
with. I have a feeling this bug depends on the order the modules get
processed in or something, as two different times I hosed my test
repository by copying back in something that I had taken out earlier.
After that, nothing I did could make it fail again. So if it stops
working, just untar and start over :)
Repository data is here: http://i.cantcode.com/~jack/testrepo-tag.tar.gz
The other bug happens when you delete the 'masktest' module from the
above repository. cvs2svn.py then fails with:
No origin records for branch 'xiph'.
This may or may not be a bug, but I figured I should report it just in
case. The repository data for this is here:
http://i.cantcode.com/~jack/testrepo-nobranch.tar.gz
jack.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: cvs2svn.py: two more bugs and test repositories
Posted by Jack Moffitt <ja...@xiph.org>.
> Ok, I've finally narrowed down the "finishing tag 'start'" problem to a
> 4MB repository with about 4-5 modules. Removing anything eliminates the
> error or causes a different one.
Thought I'd drop a note that Mike fixed these in rev 6567 in case anyone
else is having similar problems.
jack.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: cvs2svn.py: two more bugs and test repositories
Posted by Mike Wilcox <mi...@trouble.org.uk>.
kfogel@collab.net wrote:
>Mike Wilcox <mi...@trouble.org.uk> writes:
>
>
>>I'm not sure if this follow-up is a bit hasty though. I've been
>>following the comments added to issues 1411, 1417 and 1427. I'm not
>>sure if the comments there imply that the fault(s) has/have been found
>>and fixed, or just found :-)
>>
>>Can you get a copy of the pruned CVS repository from Karl, or should I
>>send it on elsewhere?
>>
>>
>
>I still have it; it's okay if I share it with Mike and others here?
>
>
Aye - that's fine.
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: cvs2svn.py: two more bugs and test repositories
Posted by kf...@collab.net.
Mike Wilcox <mi...@trouble.org.uk> writes:
> I'm not sure if this follow-up is a bit hasty though. I've been
> following the comments added to issues 1411, 1417 and 1427. I'm not
> sure if the comments there imply that the fault(s) has/have been found
> and fixed, or just found :-)
>
> Can you get a copy of the pruned CVS repository from Karl, or should I
> send it on elsewhere?
I still have it; it's okay if I share it with Mike and others here?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: cvs2svn.py: two more bugs and test repositories
Posted by Mike Wilcox <mi...@trouble.org.uk>.
cmpilato@collab.net wrote:
>
> Oh, *thank you*. I've been debugging this same error, but on the
> 1116th revision of a massive repository. I will start using your
> smaller repro case now.
The bad news -
Shame I didn't realise this - the data I sent Karl was a relatively
small CVS repository that showed this error.
Original report: item (3) in
http://www.contactor.se/~dast/svn/archive-2003-07/1208.shtml
Jack Moffitt wrote:
>
> Thought I'd drop a note that Mike fixed these in rev 6567 in
> case anyone else is having similar problems.
The worse news -
Sorry Mike; My version of the 1411/1427 faults still occur using rev
6567 of cvs2svn.py.
The same fault(s) as reported in the above message exist with the
privately supplied repository - the one difference is in the last entry
of the traceback:
$ rm -rf dev; python /home/mike/cvs2svn.py -s dev --create cvsroot/j_smsgw
File "/home/mike/cvs2svn.py", line 2263, in ?
main()
File "/home/mike/cvs2svn.py", line 2259, in main
convert(ctx, start_pass=start_pass)
File "/home/mike/cvs2svn.py", line 2138, in convert
_passes[i](ctx)
File "/home/mike/cvs2svn.py", line 2094, in pass4
sym_tracker.finish(dumper, ctx)
File "/home/mike/cvs2svn.py", line 1716, in finish
self.fill_tag(dumper, ctx, name, [1])
File "/home/mike/cvs2svn.py", line 1663, in fill_tag
self.fill_name(dumper, ctx, tag, 1, jit_new_rev)
File "/home/mike/cvs2svn.py", line 1650, in fill_name
is_tag, jit_new_rev)
File "/home/mike/cvs2svn.py", line 1554, in copy_descend
next_src, next_dst, is_tag, jit_new_rev)
<snip>
File "/home/mike/cvs2svn.py", line 1529, in copy_descend
dumper.copy_path(src_path, parent_rev, copy_dst, val)
File "/home/mike/cvs2svn.py", line 979, in copy_path
entries)
File "/home/mike/cvs2svn.py", line 673, in change_path
approved_entries = new_val.get(self.approved_entries) or { }
AttributeError: 'NoneType' object has no attribute 'get'
I'm not sure if this follow-up is a bit hasty though. I've been
following the comments added to issues 1411, 1417 and 1427. I'm not sure
if the comments there imply that the fault(s) has/have been found and
fixed, or just found :-)
Can you get a copy of the pruned CVS repository from Karl, or should I
send it on elsewhere?
Cheers,
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: cvs2svn.py: two more bugs and test repositories
Posted by cm...@collab.net.
Jack Moffitt <ja...@xiph.org> writes:
> Ok, I've finally narrowed down the "finishing tag 'start'" problem to a
> 4MB repository with about 4-5 modules. Removing anything eliminates the
> error or causes a different one.
>
> Running 'cvs2svn.py -v --dump-only testrepo-tag' fails with:
> File "../cvs2svn/cvs2svn.py", line 983, in copy_path entries)
> File "../cvs2svn/cvs2svn.py", line 673, in change_path
> approved_entries = new_val.get(self.approved_entries)
> AttributeError: 'NoneType' object has no attribute 'get'
>
> It looks it is tripping over the same thing as Bug #1417, just from a
> different code path.
Oh, *thank you*. I've been debugging this same error, but on the
1116th revision of a massive repository. I will start using your
smaller repro case now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org