[kudu-CR] KUDU-2693. Buffer blocks while flushing rowsets

["helifu (Code Review)" <ge...@cloudera.org>]

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12425 )

Change subject: KUDU-2693. Buffer blocks while flushing rowsets
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12425/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12425/1//COMMIT_MSG@18
PS1, Line 18: By consolidating the writes into a small number of containers, the
            : number of disk seeks and fsync calls can also be substantially reduced.
1) for the number of fsync calls: it would be only 1 for every DRS if DRS-collocated data is written into one container("row groups"), which is a little bit radical;
2) for the number of disk seeks: it's reduced indeed for the writing, but not for the reading.

but in general, it's a very good idea because the disk io will be mitigated while writing, and that will help improve reading(scan).



-- 
To view, visit http://gerrit.cloudera.org:8080/12425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacc662ba812ece8e68b0ef28f4ccdf0b7475fbc0
Gerrit-Change-Number: 12425
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 09:11:27 +0000
Gerrit-HasComments: Yes