You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/09/04 10:15:03 UTC
[GitHub] [incubator-kyuubi] lianneli opened a new issue, #3397: [FEATURE] permission control needs to support views
lianneli opened a new issue, #3397:
URL: https://github.com/apache/incubator-kyuubi/issues/3397
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### Describe the feature
View is also supported in Hive and other Apache family members, but it is not supportte in `KyuubiRangerExtension` now[](url)
### Motivation
_No response_
### Describe the solution
I modify the extension related code by adding a check layer in `CheckRule`, in which the View Logical Plans are not "optimized" .
### Additional context
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #3397: [FEATURE] permission control needs to support views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #3397:
URL: https://github.com/apache/incubator-kyuubi/issues/3397#issuecomment-1236478853
https://github.com/apache/incubator-kyuubi/commit/1989e4c7934d7f4d80f488fd0bf9e5adbda5ed9c does it work after this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #3397: [FEATURE] permission control needs to support views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #3397:
URL: https://github.com/apache/incubator-kyuubi/issues/3397#issuecomment-1240251095
yes, your solution sounds also like a good alternative. If something wrong might be reported in the future for the current way, it is worth a shot. but now let's keep it AS-IS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lianneli closed issue #3397: [FEATURE] permission control needs to support views
Posted by GitBox <gi...@apache.org>.
lianneli closed issue #3397: [FEATURE] permission control needs to support views
URL: https://github.com/apache/incubator-kyuubi/issues/3397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lianneli commented on issue #3397: [FEATURE] permission control needs to support views
Posted by GitBox <gi...@apache.org>.
lianneli commented on issue #3397:
URL: https://github.com/apache/incubator-kyuubi/issues/3397#issuecomment-1240210745
> [1989e4c](https://github.com/apache/incubator-kyuubi/commit/1989e4c7934d7f4d80f488fd0bf9e5adbda5ed9c) does it work after this?
I readed the related codes in version 1.6 just now, and found that this need has been satisfied. the solutions are different between us, but both can meet the target. Here is my idea of solutions:
1. add an extension in `injectCheckRule`. In this extension, search logical plan tree:
a. if nodes contains Views , run the `RuleAuthorization.checkPrivileges(spark, plan)`, and add `KYUUBI_AUTHZ_TAG` to all the child table node if permission allowed. Those node with `KYUUBI_AUTHZ_TAG` will not check permissions again in `RuleAuthorization`.
b. otherwise, let it go and this query will check permissions in `RuleAuthorization`.
this solution need modify `PrivilegesBuilder` at the sametime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lianneli commented on issue #3397: [FEATURE] permission control needs to support views
Posted by GitBox <gi...@apache.org>.
lianneli commented on issue #3397:
URL: https://github.com/apache/incubator-kyuubi/issues/3397#issuecomment-1240787262
> yes, your solution sounds also like a good alternative. If something wrong might be reported in the future for the current way, it is worth a shot. but now let's keep it AS-IS.
Yes, of course，it‘s just an idea sharing. The solutions now is logical completed, and I believe it will run well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #3397: [FEATURE] permission control needs to support views
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #3397:
URL: https://github.com/apache/incubator-kyuubi/issues/3397#issuecomment-1241408574
thanks for the confirmation @lianneli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org