You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by jc...@apache.org on 2019/05/02 21:27:26 UTC
[hive] branch master updated: HIVE-21675: CREATE VIEW IF NOT EXISTS
broken (Todd Lipcon reviewed by Jesus Camacho Rodriguez)
This is an automated email from the ASF dual-hosted git repository.
jcamacho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new 9bf1869 HIVE-21675: CREATE VIEW IF NOT EXISTS broken (Todd Lipcon reviewed by Jesus Camacho Rodriguez)
9bf1869 is described below
commit 9bf18692be9f3e33de912804098aacb40ef3ae9f
Author: Todd Lipcon <to...@cloudera.com>
AuthorDate: Thu May 2 14:26:45 2019 -0700
HIVE-21675: CREATE VIEW IF NOT EXISTS broken (Todd Lipcon reviewed by Jesus Camacho Rodriguez)
---
.../hive/ql/ddl/table/CreateViewOperation.java | 6 ++++-
ql/src/test/queries/clientpositive/create_view.q | 7 +++++-
.../test/results/clientpositive/create_view.q.out | 28 ++++++++++++++++++++--
3 files changed, 37 insertions(+), 4 deletions(-)
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/CreateViewOperation.java b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/CreateViewOperation.java
index bb9b189..f8d95aa 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/CreateViewOperation.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/CreateViewOperation.java
@@ -60,7 +60,11 @@ public class CreateViewOperation extends DDLOperation {
}
}
- if (!desc.isReplace() && !desc.getIfNotExists()) {
+ if (!desc.isReplace()) {
+ if (desc.getIfNotExists()) {
+ return 0;
+ }
+
// View already exists, thus we should be replacing
throw new HiveException(ErrorMsg.TABLE_ALREADY_EXISTS.getMsg(desc.getViewName()));
}
diff --git a/ql/src/test/queries/clientpositive/create_view.q b/ql/src/test/queries/clientpositive/create_view.q
index 3fe14f4..392ebf4 100644
--- a/ql/src/test/queries/clientpositive/create_view.q
+++ b/ql/src/test/queries/clientpositive/create_view.q
@@ -238,7 +238,12 @@ create view view18 as select v+1 from (select 1 as v) t;
select * from view18;
-- create view if not exists
-create view if not exists view18 as select v+1 from (select 1 as v) t;
+create view if not exists view18 as select "should be ignored";
+show create table view18;
+
+-- 'create or replace'
+create or replace view view18 as select "should replace";
+show create table view18;
DROP VIEW view1;
DROP VIEW view2;
diff --git a/ql/src/test/results/clientpositive/create_view.q.out b/ql/src/test/results/clientpositive/create_view.q.out
index f3d7520..7414d47 100644
--- a/ql/src/test/results/clientpositive/create_view.q.out
+++ b/ql/src/test/results/clientpositive/create_view.q.out
@@ -1618,16 +1618,40 @@ POSTHOOK: Input: _dummy_database@_dummy_table
POSTHOOK: Input: default@view18
#### A masked pattern was here ####
2
-PREHOOK: query: create view if not exists view18 as select v+1 from (select 1 as v) t
+PREHOOK: query: create view if not exists view18 as select "should be ignored"
PREHOOK: type: CREATEVIEW
PREHOOK: Input: _dummy_database@_dummy_table
PREHOOK: Output: database:default
PREHOOK: Output: default@view18
-POSTHOOK: query: create view if not exists view18 as select v+1 from (select 1 as v) t
+POSTHOOK: query: create view if not exists view18 as select "should be ignored"
POSTHOOK: type: CREATEVIEW
POSTHOOK: Input: _dummy_database@_dummy_table
POSTHOOK: Output: database:default
POSTHOOK: Output: default@view18
+PREHOOK: query: show create table view18
+PREHOOK: type: SHOW_CREATETABLE
+PREHOOK: Input: default@view18
+POSTHOOK: query: show create table view18
+POSTHOOK: type: SHOW_CREATETABLE
+POSTHOOK: Input: default@view18
+CREATE VIEW `view18` AS select `t`.`v`+1 from (select 1 as `v`) `t`
+PREHOOK: query: create or replace view view18 as select "should replace"
+PREHOOK: type: CREATEVIEW
+PREHOOK: Input: _dummy_database@_dummy_table
+PREHOOK: Output: database:default
+PREHOOK: Output: default@view18
+POSTHOOK: query: create or replace view view18 as select "should replace"
+POSTHOOK: type: CREATEVIEW
+POSTHOOK: Input: _dummy_database@_dummy_table
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@view18
+PREHOOK: query: show create table view18
+PREHOOK: type: SHOW_CREATETABLE
+PREHOOK: Input: default@view18
+POSTHOOK: query: show create table view18
+POSTHOOK: type: SHOW_CREATETABLE
+POSTHOOK: Input: default@view18
+CREATE VIEW `view18` AS select "should replace"
PREHOOK: query: DROP VIEW view1
PREHOOK: type: DROPVIEW
PREHOOK: Input: default@view1