[GitHub] [skywalking] wu-sheng commented on a change in pull request #6642: make sync metrics concurrency

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #6642:
URL: https://github.com/apache/skywalking/pull/6642#discussion_r603335412



##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -102,6 +102,10 @@ core:
     searchableTracesTags: ${SW_SEARCHABLE_TAG_KEYS:http.method,status_code,db.type,db.instance,mq.queue,mq.topic,mq.broker}
     # Define the set of log tag keys, which should be searchable through the GraphQL.
     searchableLogsTags: ${SW_SEARCHABLE_LOGS_TAG_KEYS:level}
+    # The number of threads used to synchronously refresh the metrics data to the storage. When the value is zero or negative, the number of processors will used as the default value.

Review comment:
       Same expression issue.

##########
File path: docs/en/setup/backend/configuration-vocabulary.md
##########
@@ -39,6 +39,8 @@ core|default|role|Option values, `Mixed/Receiver/Aggregator`. **Receiver** mode
 | - | - | maxSizeOfNetworkAddressAlias|Max size of network address detected in the be monitored system.| - | 1_000_000|
 | - | - | maxPageSizeOfQueryProfileSnapshot|The max size in every OAP query for snapshot analysis| - | 500 |
 | - | - | maxSizeOfAnalyzeProfileSnapshot|The max number of snapshots analyzed by OAP| - | 12000 |
+| - | - | syncThreads|The number of threads used to synchronously refresh the metrics data to the storage. When the value is zero or negative, the number of processors will used as the default value.| SW_CORE_SYNC_THREADS | -1 |

Review comment:
       Your default value is -1. So your explanation doesn't make sense. What exactly threads are you going to use in default?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org