You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sreenusuuda (via GitHub)" <gi...@apache.org> on 2024/02/15 15:45:18 UTC
[I] Empty logs screen when user tries to view task logs with out having tasklog.get permission [airflow]
sreenusuuda opened a new issue, #37452:
URL: https://github.com/apache/airflow/issues/37452
### Apache Airflow version
2.8.1
### If "Other Airflow 2 version" selected, which one?
_No response_
### What happened?
No Access denied message when user tries to view task logs with out having tasklog.get permission
### What you think should happen instead?
User should be shown with access denied message.
### How to reproduce
1. Create new user and assign user with can edit dags, can read dag runs, can edit dag runs permissions, can read task instances.
2. Try to login with user and click on the specific Dag.
3. Select task and click on logs.
### Operating System
mac os
### Versions of Apache Airflow Providers
_No response_
### Deployment
Docker-Compose
### Deployment details
_No response_
### Anything else?
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Empty logs screen when user tries to view task logs with out having can read task log permission [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on issue #37452:
URL: https://github.com/apache/airflow/issues/37452#issuecomment-1955210574
I just double checked and can confirm the log button in UI is displayed irrespective of the user having access to logs. So if the user is lagging permissions the access is correctly blocked. Tested with both UI as well as API.
Do you report this mainly as UI glitch and have a use case to restrict you users for this purpose? Or is this an artifact of a PEN test and you report just small glitches/inconsistencies?
Otherwise, are you willing to raise a corrective PR to render buttons in UI conditionally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Empty logs screen when user tries to view task logs with out having can read task log permission [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #37452: Empty logs screen when user tries to view task logs with out having can read task log permission
URL: https://github.com/apache/airflow/issues/37452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Empty logs screen when user tries to view task logs with out having can read task log permission [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #37452:
URL: https://github.com/apache/airflow/issues/37452#issuecomment-1961652478
> We typically receive an 'Access Denied' message when a user lacks the necessary permissions. Displaying this message helps users understand that they do not have the required permission.
In many cases this is bad security practise to reveal such condition to the user, it gives potential attacker more information that needed, so we deliberately opted for NOT FOUND in this case regardless whether the log file is there or whether you have badly configured system. This information is useless to the user, because the user cannot do anything about it, user has to report it to Deployment Manager (so person who manages airflow). And that person can (and SHOULD) look for details about the error in the log file of the webserver (and they will find it there all right).
So this is all deliberate, secure and as expected. No changes are planned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Empty logs screen when user tries to view task logs with out having can read task log permission [airflow]
Posted by "sreenusuuda (via GitHub)" <gi...@apache.org>.
sreenusuuda commented on issue #37452:
URL: https://github.com/apache/airflow/issues/37452#issuecomment-1961332028
We typically receive an 'Access Denied' message when a user lacks the necessary permissions. Displaying this message helps users understand that they do not have the required permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org