[jira] [Commented] (CALCITE-807) RexBuilder.ensureType doesn't ensure type

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634108#comment-14634108 ] 

Julian Hyde commented on CALCITE-807:
-------------------------------------

In https://github.com/apache/incubator-calcite/pull/97 [~mehant] wrote:

bq. There seems to be a bug in RexBuilder.esnureType() function when we pass 'matchNullability' = false as a parameter. The underlying equals() function compares the digest of the two types and is not aware of the 'matchNullability'. So if the nullability differs the equals would return false and we end up adding an extra cast. Below is a unit test for this issue.

bq. One solution to this issue can be adding equalsIgnoreNullability() to the RelDataType interface (while performing the comparison of digests ignoring the ' not null'). However since I am not well versed with this logic if there are other suggestions I can work on it to contributing a patch.

> RexBuilder.ensureType doesn't ensure type
> -----------------------------------------
>
>                 Key: CALCITE-807
>                 URL: https://issues.apache.org/jira/browse/CALCITE-807
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)