You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mmartell (GitHub)" <gi...@apache.org> on 2019/02/27 19:40:00 UTC

[GitHub] [geode-native] mmartell opened pull request #449: GEODE-4339: cpp ssl example


[ Full content available at: https://github.com/apache/geode-native/pull/449 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #449: GEODE-4339: cpp ssl example

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
If we changed this to something like:
```
#ifdef _MSC_VER
  char buf[MAX_PATH];
  if (_getcwd(buf, MAX_PATH)) {
    cwd = buf;
  }
#else
  char buf[PATH_MAX];
  if (getcwd(buf, PATH_MAX)) {
    cwd = buf;
  }
#endif
```
could we get rid of all the awful _MSC_VER stuff above?

[ Full content available at: https://github.com/apache/geode-native/pull/449 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] mmartell closed pull request #449: GEODE-4339: cpp ssl example

Posted by "mmartell (GitHub)" <gi...@apache.org>.
[ pull request closed by mmartell ]

[ Full content available at: https://github.com/apache/geode-native/pull/449 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #449: GEODE-4339: cpp ssl example

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Whitespace issue here?  This diff looks weird...

[ Full content available at: https://github.com/apache/geode-native/pull/449 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] mmartell commented on pull request #449: GEODE-4339: cpp ssl example

Posted by "mmartell (GitHub)" <gi...@apache.org>.
Agreed we can make this a little cleaner. (Ultimately we'll go to std::filesystem)

[ Full content available at: https://github.com/apache/geode-native/pull/449 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] mmartell commented on pull request #449: GEODE-4339: cpp ssl example

Posted by "mmartell (GitHub)" <gi...@apache.org>.
Hmm. Not seeing the issue here.

[ Full content available at: https://github.com/apache/geode-native/pull/449 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org