You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/02/09 07:49:13 UTC

Review Request 56482: AMBARI-19887 : Add AMS and Grafana to PERF cluster (Addendum patch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19887
    https://issues.apache.org/jira/browse/AMBARI-19887


Repository: ambari


Description
-------

Fixed issues in Metric Monitor install.
Modified PERF stack hooks such that only on AMS components hosts, uses & Java (Metrics Collector only) will be set up.
Fixed params.py such that Grafana picks up metrics collector VIP host.


Diffs
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py c547bd4 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py ef409e2 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py dee9d07 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py f030cfc 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py a366129 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml 03a5ab5 

Diff: https://reviews.apache.org/r/56482/diff/


Testing
-------

Manually tested.


Thanks,

Aravindan Vijayan


Re: Review Request 56482: AMBARI-19887 : Add AMS and Grafana to PERF cluster (Addendum patch)

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/#review164950
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 9, 2017, 7:55 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56482/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 7:55 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19887
>     https://issues.apache.org/jira/browse/AMBARI-19887
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed issues in Metric Monitor install.
> Modified PERF stack hooks such that only on AMS component hosts, users & Java (Metrics Collector only) will be set up.
> Fixed params.py such that Grafana picks up metrics collector VIP host.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py c547bd4 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py ef409e2 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py dee9d07 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py f030cfc 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py a366129 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml 03a5ab5 
> 
> Diff: https://reviews.apache.org/r/56482/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 56482: AMBARI-19887 : Add AMS and Grafana to PERF cluster (Addendum patch)

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/#review164946
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 9, 2017, 7:55 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56482/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 7:55 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19887
>     https://issues.apache.org/jira/browse/AMBARI-19887
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed issues in Metric Monitor install.
> Modified PERF stack hooks such that only on AMS component hosts, users & Java (Metrics Collector only) will be set up.
> Fixed params.py such that Grafana picks up metrics collector VIP host.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py c547bd4 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py ef409e2 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py dee9d07 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py f030cfc 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py a366129 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml 03a5ab5 
> 
> Diff: https://reviews.apache.org/r/56482/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 56482: AMBARI-19887 : Add AMS and Grafana to PERF cluster (Addendum patch)

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/
-----------------------------------------------------------

(Updated Feb. 9, 2017, 7:55 a.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19887
    https://issues.apache.org/jira/browse/AMBARI-19887


Repository: ambari


Description (updated)
-------

Fixed issues in Metric Monitor install.
Modified PERF stack hooks such that only on AMS component hosts, users & Java (Metrics Collector only) will be set up.
Fixed params.py such that Grafana picks up metrics collector VIP host.


Diffs
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py c547bd4 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py ef409e2 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py dee9d07 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py f030cfc 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py a366129 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml 03a5ab5 

Diff: https://reviews.apache.org/r/56482/diff/


Testing
-------

Manually tested.


Thanks,

Aravindan Vijayan