You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/22 06:59:12 UTC
Review Request 66207: Used native protobuf map in OCI v1 image spec.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66207/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
Bugs: MESOS-8702
https://issues.apache.org/jira/browse/MESOS-8702
Repository: mesos
Description
-------
Used native protobuf map in OCI v1 image spec.
Diffs
-----
include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d
src/oci/spec.cpp ad5b8bea54e000752c681a9bfd900b25a4158544
src/tests/containerizer/oci_spec_tests.cpp f9a98f635327eb0896f8d9719c8be91e5b5c69d3
Diff: https://reviews.apache.org/r/66207/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 66207: Used native protobuf map in OCI v1 image
spec.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66207/#review199745
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66206, 66207]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 22, 2018, 6:59 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66207/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 6:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in OCI v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d
> src/oci/spec.cpp ad5b8bea54e000752c681a9bfd900b25a4158544
> src/tests/containerizer/oci_spec_tests.cpp f9a98f635327eb0896f8d9719c8be91e5b5c69d3
>
>
> Diff: https://reviews.apache.org/r/66207/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66207: Used native protobuf map in OCI v1 image
spec.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66207/#review199742
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66206', '66207']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66207
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66207/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (109 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1058 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (757 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (786 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (839 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (868 ms total)
[----------] Global test environment tear-down
[==========] 934 tests from 92 test cases ran. (662241 ms total)
[ PASSED ] 933 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 215 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66207/logs/mesos-tests-stderr.log):
```
I0322 08:00:49.604401 14804 master.cpp:10248] Updating the state of task 7a63b73b-55db-42ae-8dbc-5180224fc98f of framework 9a8f1d42-10c4-4755-b178-7da15fee5cd6-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0322 08:00:49.605404 10632 slave.cpp:3873] Shutting down framework 9a8f1d42-10c4-4755-b178-7da15fee5cd6-0000
I0322 08:00:49.605404 10632 slave.cpp:6566] Shutting down executor '7a63b73b-55db-42ae-8dbc-5180224fc98f' of framework 9a8f1d42-10c4-4755-b178-7da15fee5cd6-0000 at executor(1)@10.3.1.8:49160
I0322 08:00:49.606395 10632 slave.cpp:919] Agent terminating
W0322 08:00:49.606395 10632 slave.cpp:3869] Ignoring shutdown framework 9a8f1d42-10c4-47I0322 08:00:49.415407 7680 exec.cpp:162] Version: 1.6.0
I0322 08:00:49.446409 4720 exec.cpp:236] Executor registered on agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0
I0322 08:00:49.450425 7724 executor.cpp:176] Received SUBSCRIBED event
I0322 08:00:49.455427 7724 executor.cpp:180] Subscribed executor on win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0322 08:00:49.455427 7724 executor.cpp:176] Received LAUNCH event
I0322 08:00:49.461427 7724 executor.cpp:648] Starting task 7a63b73b-55db-42ae-8dbc-5180224fc98f
I0322 08:00:49.545409 7724 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0322 08:00:49.575402 7724 executor.cpp:661] Forked command at 12840
I0322 08:00:49.607400 2164 exec.cpp:445] Executor asked to shutdown
I0322 08:00:49.608403 5128 executor.cpp:176] Received SHUTDOWN event
I0322 08:00:49.608403 5128 executor.cpp:758] Shutting down
I0322 08:00:49.608403 5128 executor.cpp:868] Sending SIGTERM to process tree at pi55-b178-7da15fee5cd6-0000 because it is terminating
I0322 08:00:49.608403 14804 master.cpp:10347] Removing task 7a63b73b-55db-42ae-8dbc-5180224fc98f with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 9a8f1d42-10c4-4755-b178-7da15fee5cd6-0000 on agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0 at slave(405)@10.3.1.8:63708 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 08:00:49.610414 15120 containerizer.cpp:2338] Destroying container 545a9f6f-eb7c-48b4-afb2-290efbb32389 in RUNNING state
I0322 08:00:49.610414 15120 containerizer.cpp:2952] Transitioning the state of container 545a9f6f-eb7c-48b4-afb2-290efbb32389 from RUNNING to DESTROYING
I0322 08:00:49.610414 14804 master.cpp:1295] Agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0 at slave(405)@10.3.1.8:63708 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0322 08:00:49.610414 14804 master.cpp:3276] Disconnecting agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0 at slave(405)@10.3.1.8:63708 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 08:00:49.611407 15120 launcher.cpp:156] Asked to destroy container 545a9f6f-eb7c-48b4-afb2-290efbb32389
I0322 08:00:49.611407 14804 master.cpp:3295] Deactivating agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0 at slave(405)@10.3.1.8:63708 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 08:00:49.611407 9116 hierarchical.cpp:344] Removed framework 9a8f1d42-10c4-4755-b178-7da15fee5cd6-0000
I0322 08:00:49.612411 9116 hierarchical.cpp:766] Agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0 deactivated
I0322 08:00:49.691401 2800 containerizer.cpp:2791] Container 545a9f6f-eb7c-48b4-afb2-290efbb32389 has exited
I0322 08:00:49.724436 9100 master.cpp:1137] Master terminating
I0322 08:00:49.726414 14804 hierarchical.cpp:609] Removed agent 9a8f1d42-10c4-4755-b178-7da15fee5cd6-S0
I0322 08:00:50.507472 12568 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 22, 2018, 6:59 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66207/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 6:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in OCI v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d
> src/oci/spec.cpp ad5b8bea54e000752c681a9bfd900b25a4158544
> src/tests/containerizer/oci_spec_tests.cpp f9a98f635327eb0896f8d9719c8be91e5b5c69d3
>
>
> Diff: https://reviews.apache.org/r/66207/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66207: Used native protobuf map in OCI v1 image
spec.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66207/#review200145
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 21, 2018, 11:59 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66207/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 11:59 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in OCI v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d
> src/oci/spec.cpp ad5b8bea54e000752c681a9bfd900b25a4158544
> src/tests/containerizer/oci_spec_tests.cpp f9a98f635327eb0896f8d9719c8be91e5b5c69d3
>
>
> Diff: https://reviews.apache.org/r/66207/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>