You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Martijn van Groningen (JIRA)" <ji...@apache.org> on 2011/05/25 13:07:47 UTC

[jira] [Created] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.

Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
------------------------------------------------------------

                 Key: SOLR-2543
                 URL: https://issues.apache.org/jira/browse/SOLR-2543
             Project: Solr
          Issue Type: Improvement
            Reporter: Martijn van Groningen
            Assignee: Martijn van Groningen
            Priority: Minor
             Fix For: 3.2


The trunk version has some methods / utilities to provide random testing.
SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.

Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated SOLR-2543:
----------------------------------------

    Attachment: SOLR-2543.patch

Attached a patch with random testing infrastructure. All tests in 3x pass with these changes. I executed: test ant in the toplevel directory.

> Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
> ------------------------------------------------------------
>
>                 Key: SOLR-2543
>                 URL: https://issues.apache.org/jira/browse/SOLR-2543
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: SOLR-2543.patch
>
>
> The trunk version has some methods / utilities to provide random testing.
> SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040421#comment-13040421 ] 

Michael McCandless commented on SOLR-2543:
------------------------------------------

OK got to the bottom of this... it was confounding:

  * TestIndexSearcher was buggy: it had a devious bug that caused it to
    open more searchers than it closed.

  * TestIndexSearcher did not catch this (SOLR-2552 fixes that)

  * Another test (SpellPossibilityIteratorTest) falsely took the fall
    for not closing all searchers, because it happens to run in the
    same JVM.

  * The logic that tests for not closing all searchers is fragile
    (each test is not guaranteed to only count its own opened
    searchers).  SOLR-2552 should also fix this...

Finally, it turns out the TestIndexSearcher bug had already been fixed
on trunk... please backport fixes from trunk to 3.x when possible,
especially test and test infra fixes!


> Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
> ------------------------------------------------------------
>
>                 Key: SOLR-2543
>                 URL: https://issues.apache.org/jira/browse/SOLR-2543
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: SOLR-2543.patch
>
>
> The trunk version has some methods / utilities to provide random testing.
> SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved SOLR-2543.
--------------------------------------

    Resolution: Fixed

Thanks Martijn!

> Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
> ------------------------------------------------------------
>
>                 Key: SOLR-2543
>                 URL: https://issues.apache.org/jira/browse/SOLR-2543
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: SOLR-2543.patch
>
>
> The trunk version has some methods / utilities to provide random testing.
> SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040381#comment-13040381 ] 

Michael McCandless commented on SOLR-2543:
------------------------------------------

I'm not sure why, but when I apply this patch and then run "ant test" from solr subdir, this test consistently fails:
{noformat}
    [junit] Testsuite: org.apache.solr.spelling.SpellPossibilityIteratorTest
    [junit] Testcase: org.apache.solr.spelling.SpellPossibilityIteratorTest:	FAILED
    [junit] ERROR: SolrIndexSearcher opens=10 closes=9
    [junit] junit.framework.AssertionFailedError: ERROR: SolrIndexSearcher opens=10 closes=9
    [junit] 	at org.apache.solr.SolrTestCaseJ4.endTrackingSearchers(SolrTestCaseJ4.java:119)
    [junit] 	at org.apache.solr.SolrTestCaseJ4.deleteCore(SolrTestCaseJ4.java:293)
    [junit] 	at org.apache.solr.SolrTestCaseJ4.afterClassSolrTestCase(SolrTestCaseJ4.java:70)
{noformat}

If I run {{ant test -Dtestcase=SpellPossibilityTest}} then it does not fail.  Very strange.

> Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
> ------------------------------------------------------------
>
>                 Key: SOLR-2543
>                 URL: https://issues.apache.org/jira/browse/SOLR-2543
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: SOLR-2543.patch
>
>
> The trunk version has some methods / utilities to provide random testing.
> SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039092#comment-13039092 ] 

Michael McCandless commented on SOLR-2543:
------------------------------------------

This is excellent Martijn!

In this backport, are there any 3.x tests that use the random test infra?  I know SOLR-2524 needs it, but that random test is failing, and we don't know if it's a bug in the test or a bug in this backport?  Maybe there's a simple 3.x test we can cutover to the random infra to try to debug it?

> Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
> ------------------------------------------------------------
>
>                 Key: SOLR-2543
>                 URL: https://issues.apache.org/jira/browse/SOLR-2543
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: SOLR-2543.patch
>
>
> The trunk version has some methods / utilities to provide random testing.
> SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org