When building locally TomEE has tons of broken tests.

[Mark Struberg <st...@yahoo.de.INVALID>]

IF we want to increase the community activity, then we first need to have a stable local build.
One has to checkout, run mvn clean install and get a green build. 
Currently that's just not the case. It seems that the tests only run fine on the CI box. That's a showstopper for any community involvement.
I've started tracking down those tests in error. I can test Linux and OSX in parallel
Starting with https://issues.apache.org/jira/browse/TOMEE-2088
LieGrue,strub

Re: When building locally TomEE has tons of broken tests.

[Jonathan Gallimore <jo...@gmail.com>]

Awesome, thanks Mark!

On Mon, Jul 10, 2017 at 9:30 AM, Mark Struberg <st...@yahoo.de.invalid>
wrote:

> I've created a new component 'TomEE Build' while creating that ticket.
>
> LieGrue,
> strub
>
> > Am 10.07.2017 um 10:21 schrieb Jonathan Gallimore <
> jonathan.gallimore@gmail.com>:
> >
> > Thanks Mark!
> >
> > I'd definitely appreciate a list of the test failures you see - I'm happy
> > to muck in and help fix. Interestingly I do have an OSX mac mini under my
> > desk which I use to run builds and it does a fresh checkout and the tests
> > do pass. Its a Core i5 with 8GB of RAM and a very vanilla OSX install on
> > it, so nothing special. That said I'm happy to find some way to reproduce
> > failures and fix.
> >
> > Do we want to track test failures as subtasks under one specific JIRA, or
> > each test as a specific JIRA but with a label so its easy to list them
> out?
> >
> > Jon
> >
> > On Mon, Jul 10, 2017 at 7:53 AM, Mark Struberg <struberg@yahoo.de.invalid
> >
> > wrote:
> >
> >> IF we want to increase the community activity, then we first need to
> have
> >> a stable local build.
> >> One has to checkout, run mvn clean install and get a green build.
> >> Currently that's just not the case. It seems that the tests only run
> fine
> >> on the CI box. That's a showstopper for any community involvement.
> >> I've started tracking down those tests in error. I can test Linux and
> OSX
> >> in parallel
> >> Starting with https://issues.apache.org/jira/browse/TOMEE-2088
> >> LieGrue,strub
> >>
>
>

Re: When building locally TomEE has tons of broken tests.

[Mark Struberg <st...@yahoo.de.INVALID>]

I've created a new component 'TomEE Build' while creating that ticket.

LieGrue,
strub

> Am 10.07.2017 um 10:21 schrieb Jonathan Gallimore <jo...@gmail.com>:
> 
> Thanks Mark!
> 
> I'd definitely appreciate a list of the test failures you see - I'm happy
> to muck in and help fix. Interestingly I do have an OSX mac mini under my
> desk which I use to run builds and it does a fresh checkout and the tests
> do pass. Its a Core i5 with 8GB of RAM and a very vanilla OSX install on
> it, so nothing special. That said I'm happy to find some way to reproduce
> failures and fix.
> 
> Do we want to track test failures as subtasks under one specific JIRA, or
> each test as a specific JIRA but with a label so its easy to list them out?
> 
> Jon
> 
> On Mon, Jul 10, 2017 at 7:53 AM, Mark Struberg <st...@yahoo.de.invalid>
> wrote:
> 
>> IF we want to increase the community activity, then we first need to have
>> a stable local build.
>> One has to checkout, run mvn clean install and get a green build.
>> Currently that's just not the case. It seems that the tests only run fine
>> on the CI box. That's a showstopper for any community involvement.
>> I've started tracking down those tests in error. I can test Linux and OSX
>> in parallel
>> Starting with https://issues.apache.org/jira/browse/TOMEE-2088
>> LieGrue,strub
>> 

Re: When building locally TomEE has tons of broken tests.

[Jonathan Gallimore <jo...@gmail.com>]

Thanks Mark!

I'd definitely appreciate a list of the test failures you see - I'm happy
to muck in and help fix. Interestingly I do have an OSX mac mini under my
desk which I use to run builds and it does a fresh checkout and the tests
do pass. Its a Core i5 with 8GB of RAM and a very vanilla OSX install on
it, so nothing special. That said I'm happy to find some way to reproduce
failures and fix.

Do we want to track test failures as subtasks under one specific JIRA, or
each test as a specific JIRA but with a label so its easy to list them out?

Jon

On Mon, Jul 10, 2017 at 7:53 AM, Mark Struberg <st...@yahoo.de.invalid>
wrote:

> IF we want to increase the community activity, then we first need to have
> a stable local build.
> One has to checkout, run mvn clean install and get a green build.
> Currently that's just not the case. It seems that the tests only run fine
> on the CI box. That's a showstopper for any community involvement.
> I've started tracking down those tests in error. I can test Linux and OSX
> in parallel
> Starting with https://issues.apache.org/jira/browse/TOMEE-2088
> LieGrue,strub
>

Re: When building locally TomEE has tons of broken tests.

[Romain Manni-Bucau <rm...@gmail.com>]

2017-07-10 8:53 GMT+02:00 Mark Struberg <st...@yahoo.de.invalid>:

> IF we want to increase the community activity, then we first need to have
> a stable local build.
> One has to checkout, run mvn clean install and get a green build.
> Currently that's just not the case. It seems that the tests only run fine
> on the CI box. That's a showstopper for any community involvement.
>

linux boxes actually. We also have some timing related tests which can fail
on slow machines but increasing too much the timeout will just lead to
removing the test.

We sometimes got some proposal to have a fast default profile build but not
sure it helps since contributors would IMHO feel insulted by us faking them
a green build.

Wonder if we could propose a set of test by modification area, like "run
X1Test, X2Test, X3Test" if you modify injections, "X4Test" if you modify
the datasource pooling, etc...


> I've started tracking down those tests in error. I can test Linux and OSX
> in parallel
> Starting with https://issues.apache.org/jira/browse/TOMEE-2088
> LieGrue,strub
>