[GitHub] [superset] zhaoyongjie edited a comment on issue #15956: Time Series viz shows incorrect legend for multiple group by columns

[GitBox <gi...@apache.org>]

zhaoyongjie edited a comment on issue #15956:
URL: https://github.com/apache/superset/issues/15956#issuecomment-889588923


   @serenajiang 
   I think this is by design(the same logic is also in the NVD3 line chart.)
   For echart timeseries and NVD3 line chart
   1. x-axis is continuous datatime(__timestamp in SQL)
   2. y-axis are metrics(the metrics in the metrics control)
   3. datamark are permutations of the columns values(values of groupby control)
   4. we should add some `filter` to limit permutations.
   
   for instance(use cleaned_sales_data):
   this viz means: sum of sales per day for the large deal in California USA in 2003
   
   <img width="1250" alt="image" src="https://user-images.githubusercontent.com/2016594/127592295-c3bf3a88-8564-4318-8891-167ffa52edde.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org