You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/10 09:10:34 UTC
[GitHub] [incubator-iotdb] LebronAl opened a new pull request #1344: change infertype
LebronAl opened a new pull request #1344:
URL: https://github.com/apache/incubator-iotdb/pull/1344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] LebronAl closed pull request #1344: [Distributed] change infertype
Posted by GitBox <gi...@apache.org>.
LebronAl closed pull request #1344:
URL: https://github.com/apache/incubator-iotdb/pull/1344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1344: change infertype
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #1344:
URL: https://github.com/apache/incubator-iotdb/pull/1344#discussion_r437992800
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertPlan.java
##########
@@ -461,9 +461,7 @@ public void deserialize(ByteBuffer buffer) {
}
// the types are not inferred before the plan is serialized
- if (types[0] == null) {
- this.inferType = true;
- }
+ this.inferType = true;
Review comment:
Hi, the serializedPlan should already have specific data types. I think this field should be false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] LebronAl commented on a change in pull request #1344: [Distributed] change infertype
Posted by GitBox <gi...@apache.org>.
LebronAl commented on a change in pull request #1344:
URL: https://github.com/apache/incubator-iotdb/pull/1344#discussion_r438013080
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertPlan.java
##########
@@ -461,9 +461,7 @@ public void deserialize(ByteBuffer buffer) {
}
// the types are not inferred before the plan is serialized
- if (types[0] == null) {
- this.inferType = true;
- }
+ this.inferType = true;
Review comment:
I found I can't insert data to cluster_new just an hour ago.And I found the changes in this [commit](https://github.com/apache/incubator-iotdb/commit/34ea36f50fcee41f8f18a01a24bfee8b040f9a52) resulting this bug.Now @jt2594838 has fix this bug by serializing the inferFlag in this [commit](https://github.com/apache/incubator-iotdb/commit/cad7680e67dccfc8de1de85fe6f9e70539f10641).I will close this PR.
Thanks for reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org