You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/10 03:36:38 UTC
[GitHub] [incubator-pinot] sunithabeeram commented on issue #4025: Extend
stream interfaces to expose message metadata like ingestion timestamp
sunithabeeram commented on issue #4025: Extend stream interfaces to expose message metadata like ingestion timestamp
URL: https://github.com/apache/incubator-pinot/pull/4025#issuecomment-481520442
@mayankshriv:
1. The interface modification has been kept generic enough to allow other metadata to be included from stream->mutable segment.
2. #3979 and other changes will wire this up. The specific classes that implement the MessageBatch or MessageDecoder will eventually provide the values needed.
3. We definitely considered this option - but accessing the information through segment metadata is a lot more cleaner than other options. I have an updated to the other PR - will push it now. You can review that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org