You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ap...@apache.org on 2018/11/21 18:27:37 UTC
[incubator-pinot] branch master updated: [TE] roocause - fix
dimension table metric select/unselect (#3533)
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0389a6c [TE] roocause - fix dimension table metric select/unselect (#3533)
0389a6c is described below
commit 0389a6c82df4f36f20242685980417375b79b5ac
Author: Alexander Pucher <ap...@linkedin.com>
AuthorDate: Wed Nov 21 10:27:32 2018 -0800
[TE] roocause - fix dimension table metric select/unselect (#3533)
---
.../app/pods/components/rootcause-dimensions-table/component.js | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
index 29be3f1..0e5969e 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
@@ -3,6 +3,7 @@ import Component from '@ember/component';
import {
toCurrentUrn,
toBaselineUrn,
+ toMetricUrn,
isInverse,
toColorDirection,
makeSortable,
@@ -125,7 +126,7 @@ export default Component.extend({
Object.keys(current[name]).forEach(value => {
if (value === ROOTCAUSE_VALUE_OTHER) { return; }
- const urn = appendFilters(metricUrn, [[name, value]]);
+ const urn = appendFilters(metricUrn, [[name, '=', value]]);
const curr = (current[name] || {})[value] || 0;
const base = (baseline[name] || {})[value] || 0;
@@ -209,11 +210,7 @@ export default Component.extend({
const urn = e.selectedItems[0].urn;
const state = !selectedUrns.has(urn);
- const updates = {[urn]: state};
- if (hasPrefix(urn, 'thirdeye:metric:')) {
- updates[toCurrentUrn(urn)] = state;
- updates[toBaselineUrn(urn)] = state;
- }
+ const updates = { [toMetricUrn(urn)]: state, [toCurrentUrn(urn)]: state, [toBaselineUrn(urn)]: state };
set(this, 'preselectedItems', []);
onSelection(updates);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org