You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/12/01 23:33:38 UTC
Review Request 40843: Enforce granular role-based access control for
group functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40843/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-14142
https://issues.apache.org/jira/browse/AMBARI-14142
Repository: ambari
Description
-------
Enforce granular role-based access control for alert functions:
| Cluster User | Service Operator | Service Administrator | Cluster Operator | ClusterAdministrator | Administrator
--------------|--------------|------------------|-----------------------|------------------|----------------------|---------------
Manage groups | | | | | | (+)
Entry points affected:
* GET /api/v1/groups
* GET /api/v1/groups/:group_name
* PUT /api/v1/groups/:group_name
* POST /api/v1/groups/:group_name
* DELETE /api/v1/groups/:group_name
* GET /api/v1/groups/:group_name/members
* PUT /api/v1/groups/:group_name/members
* POST /api/v1/groups/:group_name/members
* DELETE /api/v1/groups/:group_name/members
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java 36e1007
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java 0f6b66d
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 7f88286
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java 0cd1be1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java da8d781
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java d4b7d5a
Diff: https://reviews.apache.org/r/40843/diff/
Testing
-------
Manually tested
# Local test results: PASSED
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 40843: Enforce granular role-based access control
for group functions
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40843/#review108648
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 1, 2015, 5:34 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40843/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 5:34 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-14142
> https://issues.apache.org/jira/browse/AMBARI-14142
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | ClusterAdministrator | Administrator
> --------------|--------------|------------------|-----------------------|------------------|----------------------|---------------
> Manage groups | | | | | | (+)
>
> Entry points affected:
> - GET /api/v1/groups
> - GET /api/v1/groups/:group_name
> - PUT /api/v1/groups/:group_name
> - POST /api/v1/groups/:group_name
> - DELETE /api/v1/groups/:group_name
> - GET /api/v1/groups/:group_name/members
> - PUT /api/v1/groups/:group_name/members
> - POST /api/v1/groups/:group_name/members
> - DELETE /api/v1/groups/:group_name/members
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java 36e1007
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java 0f6b66d
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 7f88286
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java 0cd1be1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java da8d781
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java d4b7d5a
>
> Diff: https://reviews.apache.org/r/40843/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results: PASSED
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 40843: Enforce granular role-based access control
for group functions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40843/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 5:34 p.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-14142
https://issues.apache.org/jira/browse/AMBARI-14142
Repository: ambari
Description (updated)
-------
Enforce granular role-based access control for alert functions:
| Cluster User | Service Operator | Service Administrator | Cluster Operator | ClusterAdministrator | Administrator
--------------|--------------|------------------|-----------------------|------------------|----------------------|---------------
Manage groups | | | | | | (+)
Entry points affected:
- GET /api/v1/groups
- GET /api/v1/groups/:group_name
- PUT /api/v1/groups/:group_name
- POST /api/v1/groups/:group_name
- DELETE /api/v1/groups/:group_name
- GET /api/v1/groups/:group_name/members
- PUT /api/v1/groups/:group_name/members
- POST /api/v1/groups/:group_name/members
- DELETE /api/v1/groups/:group_name/members
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java 36e1007
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java 0f6b66d
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 7f88286
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java 0cd1be1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java da8d781
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java d4b7d5a
Diff: https://reviews.apache.org/r/40843/diff/
Testing
-------
Manually tested
# Local test results: PASSED
# Jenkins test results: PENDING
Thanks,
Robert Levas