You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by se...@apache.org on 2015/08/10 17:22:36 UTC

svn commit: r1695113 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java

Author: sebb
Date: Mon Aug 10 15:22:35 2015
New Revision: 1695113

URL: http://svn.apache.org/r1695113
Log:
Don't call overrideable methods from a constructor

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java?rev=1695113&r1=1695112&r2=1695113&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java Mon Aug 10 15:22:35 2015
@@ -34,7 +34,7 @@ public class AnnotationDefault extends A
     
     private static final long serialVersionUID = -4017327188724019487L;
 
-    private ElementValue default_value;
+    private ElementValue default_value; // TODO could this be made final?
 
     /**
      * @param name_index    Index pointing to the name <em>Code</em>
@@ -55,7 +55,7 @@ public class AnnotationDefault extends A
      */
     public AnnotationDefault(int name_index, int length, ElementValue defaultValue, ConstantPool constant_pool) {
         super(Constants.ATTR_ANNOTATION_DEFAULT, name_index, length, constant_pool);
-        setDefaultValue(defaultValue);
+        this.default_value = defaultValue;
     }
 
     /**